pon., 6 paź 2025 o 17:47 John Maddock via Boost <boost@lists.boost.org> napisał(a):
The second review of the proposed Decimal Number library by Matt Borland and Chris Kormanyos begins today and runs until 15th Oct.
You will find documentation here: https://develop.decimal.cpp.al/decimal/overview.html
And the code repository is here: https://github.com/cppalliance/decimal/
Boost.Decimal is an implementation of IEEE 754 <https://standards.ieee.org/ieee/754/6210/> <https://standards.ieee.org/ieee/754/6210/%3E> and ISO/IEC DTR 24733 <https://www.open-std.org/JTC1/SC22/WG21/docs/papers/2009/n2849.pdf> <https://www.open-std.org/JTC1/SC22/WG21/docs/papers/2009/n2849.pdf%3E> Decimal Floating Point numbers.
Thank you for the update, and thank you for the author's efforts to deliver the second incarnation of the library. A couple of quick questions. Regarding the ISO/IEC DTR 24733, shall we treat Boost.Decimal as a literal implementation of that TR up to the last detail, or rather that it wanted to be as close as reasonable but not closer. For instance, N2849 has a different initialization interface for the decimal types. From the documentation on rounding modes ( https://develop.decimal.cpp.al/decimal/examples.html#examples_rounding_mode), I cannot figure out how I actually get to control it for my operations. Do I just create the object and as long as it is in scope all my operations have the altered mode? Or do I need to pass it to operations? If the former, does it have all the problems that globals have? For instance, the interactions with coroutines where the same lexical scope can start on one thread and finish on another? Anyway, the documentation on the rounding mode is missing. The link points to the branch `develop` on GitHub. Is it the branch `develop` that is the subject of the review? Regards, &rzej;
The library is header-only, has no dependencies, and requires C++14.
This re-review is happening because the original review had an indeterminate result (see my summary at
https://lists.boost.org/archives/list/boost@lists.boost.org/message/2Q7UBOTE...)
and resulted in my filing a number of issues against the library based on the reviewers comments. Now that Matt and Chris have been busy fixing these and addressing the reviewers concerns, the library is now back for a second look, see
https://github.com/cppalliance/decimal/issues?q=is%3Aissue%20state%3Aclosed%... for a complete list of issues addressed from the last review.
I hope both the original reviewers, and new ones will come back for a second look.
Please feel free to amend your original review, or if you're starting from scratch then please provide feedback on the following general topics:
- What is your evaluation of the design?
- What is your evaluation of the implementation?
- What is your evaluation of the documentation?
- What is your evaluation of the potential usefulness of the library?
- Do you already use it in industry?
- Did you try to use the library? With which compiler(s)? Did you have any problems?
- How much effort did you put into your evaluation? A glance? A quick reading? In-depth study?
- Are you knowledgeable about the problem domain?
Ensure to explicitly include with your review: ACCEPT, REJECT, or CONDITIONAL ACCEPT (with acceptance conditions).
Best, John Maddock (review manager).
_______________________________________________ Boost mailing list -- boost@lists.boost.org To unsubscribe send an email to boost-leave@lists.boost.org https://lists.boost.org/mailman3/lists/boost.lists.boost.org/ Archived at: https://lists.boost.org/archives/list/boost@lists.boost.org/message/2GQFSND3...