Em qua., 20 de ago. de 2025 às 07:41, Claudio DeSouza via Boost <boost@lists.boost.org> escreveu:
I'm also a bit confused about this, because there seems to be conflicting statements even in this thread. Vinnicius early, whilst praising Chris policy, said:
"Every time I've reached out to improve FreeBSD support (even in niche cases), the changes were accepted (most of the times Chris rewrote the changes himself, but got the job done anyways)."
And
"You have to follow the commit history to see if your changes got accepted because most of the time Chris rewrites the patches to not delay fixes even further (instead of asking for changes and then waiting until you get the patches to his liking)."
So I'm not sure how to interpret that, and other Asio contributors could better explain what normally happens in these cases.
I'm sorry for my lack of clarity. My point was that ASIO is *not* just a helper tool for Chris' personal work. Changes to ASIO unrelated to Chris' daily work do get accepted into ASIO. I developed a project similar to NodeJS (but using Lua instead of JS) that uses ASIO. My project was somewhat ambitious and can do things that the JS community won't ever do (e.g. suid binaries, containers and sandboxes w/o relying on 3rd party runtimes). As part of this work, I needed tight integration with many UNIX details that I'm sure Chris doesn't care about in his daily work, but merged the changes I requested anyway (e.g. avoiding FIONBIO on assigned file descriptors as ioctl are dangerous if you're handling a resource received from a sandbox). That's the first point: Chris accepts changes that don't affect his daily work (even when they're debatably niche cases). Now to the second point: he does rewrite a lot of the patches you send. I wrote/submitted a number of patches, but only 3 got accepted as-is. Implementation-wise, the rewritten code didn't lose anything to my implementation (usually they're equivalent or superior taking many more ASIO internals into account). Commit history-wise, my commit messages were better and explained problems in minute detail. I wouldn't mind if he instead copy-paste'd my commit messages as it'd better record why the changes are necessary. A bit more clarification about one of the experiences I shared earlier: I did spend time writing patches to improve FreeBSD support in the past. FreeBSD support improved, but not sufficiently. There are still 2 changes -- one small and one medium -- to have FreeBSD on par with other platforms. I actually managed to persuade FreeBSD devs to add new functions in the base system to better accommodate ASIO needs (e.g. aio_read2) so it's a bit of a shame that ASIO isn't still using them. However I'm no longer actively working on improving ASIO. I moved to other stuff (although I'm still a heavy ASIO user) and I won't be writing patches to further improve FreeBSD support (reach out to me if you're interested; I still would be willing to mentor if someone else is the one doing the heavy work). -- Vinícius dos Santos Oliveira