All- Sometime around 7pm yesterday (2-17) a commit went in (master and develop?, regression scripts?) that broke all my regression runners (linux and windows). I haven't had a ton of time to dig in, but the end of the results look like this: notice: using boost library auto_config <layout>system ../libs/contract/test/Jamfile.v2:417: Unescaped special character in argument <define>BOOST_CONTRACT_ON_MISSING_CHECK_DECL="{ throw err(); }" notice: [libjpeg] Using pre-installed library notice: [libjpeg] Condition notice: [zlib] zlib is already configured notice: [libpng] Using pre-installed library notice: [libpng] Condition notice: [libtiff] Using pre-installed library notice: [libtiff] Condition /var/boost/run/boost_bb/src/build/feature.jam:447: in extend-feature from module feature error: coverage is already associated with the "<variant>" feature /var/boost/run/boost_bb/src/build/feature.jam:624: in feature.extend from module feature /var/boost/run/boost_bb/src/tools/features/variant-feature.jam:79: in variant from module variant-feature ../libs/histogram/Jamfile:15: in modules.load from module Jamfile</var/boost/run/boost_root/libs/histogram> /var/boost/run/boost_bb/src/build/project.jam:372: in load-jamfile from module project /var/boost/run/boost_bb/src/build/project.jam:64: in load from module project /var/boost/run/boost_bb/src/build/project.jam:109: in load-parent from module project /var/boost/run/boost_bb/src/build/project.jam:513: in initialize from module project /var/boost/run/boost_bb/src/build/project.jam:348: in load-jamfile from module project /var/boost/run/boost_bb/src/build/project.jam:64: in load from module project /var/boost/run/boost_bb/src/build/project.jam:142: in project.find from module project Jamfile.v2:122: in run-tests from module Jamfile</var/boost/run/boost_root/status> Jamfile.v2:196: in modules.load from module Jamfile</var/boost/run/boost_root/status> /var/boost/run/boost_bb/src/build/project.jam:372: in load-jamfile from module project /var/boost/run/boost_bb/src/build/project.jam:64: in load from module project /var/boost/run/boost_bb/src/build/project.jam:142: in project.find from module project /var/boost/run/boost_bb/src/build-system.jam:618: in load from module build-system /var/boost/run/boost_bb/src/kernel/modules.jam:295: in import from module modules /var/boost/run/boost_bb/src/kernel/bootstrap.jam:139: in boost-build from module /var/boost/run/boost_root/boost-build.jam:17: in module scope from module Any thoughts? Tom
Tom Kent wrote:
All- Sometime around 7pm yesterday (2-17) a commit went in (master and develop?, regression scripts?) that broke all my regression runners (linux and windows).
It's this one: https://github.com/boostorg/histogram/commit/9abbe46e3dd57e2b55f7ab52eaed159...
I haven't had a ton of time to dig in, but the end of the results look like this: ... error: coverage is already associated with the "<variant>" feature /var/boost/run/boost_bb/src/build/feature.jam:624: in feature.extend from module feature /var/boost/run/boost_bb/src/tools/features/variant-feature.jam:79: in variant from module variant-feature ../libs/histogram/Jamfile:15: in modules.load from module Jamfile</var/boost/run/boost_root/libs/histogram>
Hi Tom, Peter,
On 19. Feb 2019, at 04:29, Peter Dimov via Boost <boost@lists.boost.org> wrote:
Tom Kent wrote:
All- Sometime around 7pm yesterday (2-17) a commit went in (master and develop?, regression scripts?) that broke all my regression runners (linux and windows).
It's this one: https://github.com/boostorg/histogram/commit/9abbe46e3dd57e2b55f7ab52eaed159...
so it was me, sorry. This error didn't show up in my unit test. It seems to come from my `coverage` variant, which I copied and modified from beast, where it seems to work fine. Should I revert these changes to repair the tests quickly until I have a proper understanding of the problem or do you recommend another course of action? Best regards, Hans
On Tue, 19 Feb 2019 at 11:49, Hans Dembinski via Boost <boost@lists.boost.org> wrote:
On 19. Feb 2019, at 04:29, Peter Dimov via Boost <boost@lists.boost.org> wrote:
Tom Kent wrote:
All- Sometime around 7pm yesterday (2-17) a commit went in (master and develop?, regression scripts?) that broke all my regression runners (linux and windows).
It's this one: https://github.com/boostorg/histogram/commit/9abbe46e3dd57e2b55f7ab52eaed159...
so it was me, sorry. This error didn't show up in my unit test. It seems to come from my `coverage` variant, which I copied and modified from beast, where it seems to work fine.
You seem to be running `b2 -j2 -q toolset=gcc-7 coverage`, while it should read `variant=coverage` AFAIS, Beast's `.travis.yml` sets `VARIANT` and other env variables, then calls `libs/beast/tools/retry.sh libs/beast/tools/build-and-test.sh` which composes the `b2` command line Your `.travis.yml` + `Jamfile` do things similar, but different Best regards, -- Mateusz Loskot, http://mateusz.loskot.net
On Tue, 19 Feb 2019 at 12:23, Mateusz Loskot <mateusz@loskot.net> wrote:
On Tue, 19 Feb 2019 at 11:49, Hans Dembinski via Boost <boost@lists.boost.org> wrote:
On 19. Feb 2019, at 04:29, Peter Dimov via Boost <boost@lists.boost.org> wrote:
Tom Kent wrote:
All- Sometime around 7pm yesterday (2-17) a commit went in (master and develop?, regression scripts?) that broke all my regression runners (linux and windows).
It's this one: https://github.com/boostorg/histogram/commit/9abbe46e3dd57e2b55f7ab52eaed159...
so it was me, sorry. This error didn't show up in my unit test. It seems to come from my `coverage` variant, which I copied and modified from beast, where it seems to work fine.
You seem to be running `b2 -j2 -q toolset=gcc-7 coverage`, while it should read `variant=coverage`
AFAIS, Beast's `.travis.yml` sets `VARIANT` and other env variables, then calls `libs/beast/tools/retry.sh libs/beast/tools/build-and-test.sh` which composes the `b2` command line
I take that back. Boost.Build fu shortage here. Your use seems fine [1], ass we've got it clarified on Slack. [1] https://boostorg.github.io/build/manual/develop/index.html "The release and debug that we have seen in b2 invocations are just a shorthand way to specify values of the variant feature." Best regards, -- Mateusz Loskot, http://mateusz.loskot.net
AMDG On 2/19/19 3:48 AM, Hans Dembinski via Boost wrote:
On 19. Feb 2019, at 04:29, Peter Dimov via Boost <boost@lists.boost.org> wrote:
Tom Kent wrote:
All- Sometime around 7pm yesterday (2-17) a commit went in (master and develop?, regression scripts?) that broke all my regression runners (linux and windows).
It's this one: https://github.com/boostorg/histogram/commit/9abbe46e3dd57e2b55f7ab52eaed159...
so it was me, sorry. This error didn't show up in my unit test. It seems to come from my `coverage` variant, which I copied and modified from beast, where it seems to work fine.
It works fine... until you try to build both beast and histogram at the same time. That causes a duplicate definition error.
Should I revert these changes to repair the tests quickly until I have a proper understanding of the problem or do you recommend another course of action?
In Christ, Steven Watanabe
On Tue, Feb 19, 2019 at 8:34 AM Steven Watanabe via Boost <boost@lists.boost.org> wrote:
This error didn't show up in my unit test. It seems to come from my `coverage` variant, which I copied and modified from beast, where it seems to work fine.
FYI, Beast develop branch is profoundly broken with the recent update to Boost.Asio. We are working on fixing it but Chris is at the C++ meeting and we will need his help to resolve some of the issues. I will not be able to fix the regression in the matrix until after these other problems are solved (could persist until next week). Regards
participants (6)
-
Hans Dembinski -
Mateusz Loskot -
Peter Dimov -
Steven Watanabe -
Tom Kent -
Vinnie Falco