[core] Move underlying_type to type_traits?
While documenting and cleaning up scoped_enum.hpp I factored out the underlying_type trait to a separate header. Mostly, because I didn't want to #include <type_traits> in scoped_enum.hpp. boost::underlying_type should be equivalent to std::underlying_type, except that it also supports emulated scoped enums. Perhaps boost/core/underlying_type.hpp should be moved to Boost.TypeTraits?
Le 04/06/14 22:28, Andrey Semashev a écrit :
While documenting and cleaning up scoped_enum.hpp I factored out the underlying_type trait to a separate header. Mostly, because I didn't want to #include <type_traits> in scoped_enum.hpp. boost::underlying_type should be equivalent to std::underlying_type, except that it also supports emulated scoped enums.
Perhaps boost/core/underlying_type.hpp should be moved to Boost.TypeTraits?
I have no problem with this move. We will need some documentation and test if it becomes public. Vicente
On Wednesday 04 June 2014 23:03:28 Vicente J. Botet Escriba wrote:
Le 04/06/14 22:28, Andrey Semashev a écrit :
While documenting and cleaning up scoped_enum.hpp I factored out the underlying_type trait to a separate header. Mostly, because I didn't want to #include <type_traits> in scoped_enum.hpp. boost::underlying_type should be equivalent to std::underlying_type, except that it also supports emulated scoped enums.
Perhaps boost/core/underlying_type.hpp should be moved to Boost.TypeTraits?
I have no problem with this move. We will need some documentation and test if it becomes public.
I've put a brief description in the scoped_enum.hpp docs. No tests though.
Andrey Semashev wrote:
Perhaps boost/core/underlying_type.hpp should be moved to Boost.TypeTraits?
Not sure what we'd gain from that. Ideally, it will be moved to the core type traits, one day. In the meantime, since it's in core/, it'd be nice if it can acquire a test. :-) Ditto for scoped_enum.
On Wed, Jun 4, 2014 at 5:09 PM, Peter Dimov <lists@pdimov.com> wrote:
Andrey Semashev wrote:
Perhaps boost/core/underlying_type.hpp should be moved to
Boost.TypeTraits?
Not sure what we'd gain from that. Ideally, it will be moved to the core type traits, one day.
In the meantime, since it's in core/, it'd be nice if it can acquire a test. :-)
Ditto for scoped_enum.
IIRC, scoped_enum does have a test, or at least had one once. I'll take a look later to see if my memory is in fact correct:-) --Beman
participants (4)
-
Andrey Semashev -
Beman Dawes -
Peter Dimov -
Vicente J. Botet Escriba