1.59 release notes don't mention new property_tree::json_parser
The commit logs say: TL;DR: The new parser fixes long-standing bugs and has full Unicode support, but removes non-standard extensions of the old parser, which could break code: - String concatenation: the old parser concatenated adjacent string literals like C does. - Comments: the old parser supported C and C++-style comments. JSON doesn't allow comments. Removing support for comments did break something. Unfortunately there was no sign of this in the release notes, so I had to debug it the hard way (in code that swallowed the exception from the parser - gah!) and only found the commit message once I already knew what the problem was. </rant>
Same thing happened to me, suddenly my application stopped to work. I really think it should accept comments. /Viktor On Wed, Sep 2, 2015 at 7:18 PM Jonathan Wakely <jwakely.boost@kayari.org> wrote:
The commit logs say:
TL;DR: The new parser fixes long-standing bugs and has full Unicode support, but removes non-standard extensions of the old parser, which could break code: - String concatenation: the old parser concatenated adjacent string literals like C does. - Comments: the old parser supported C and C++-style comments. JSON doesn't allow comments.
Removing support for comments did break something. Unfortunately there was no sign of this in the release notes, so I had to debug it the hard way (in code that swallowed the exception from the parser - gah!) and only found the commit message once I already knew what the problem was.
</rant>
_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
On 10 September 2015 at 07:47, Viktor Sehr wrote:
Same thing happened to me, suddenly my application stopped to work. I really think it should accept comments.
A parser option to allow/disallow comments would be nice, but at a minimum the breaking change should be documented in the release notes, not buried away in git commit logs.
/Viktor
On Wed, Sep 2, 2015 at 7:18 PM Jonathan Wakely <jwakely.boost@kayari.org> wrote:
The commit logs say:
TL;DR: The new parser fixes long-standing bugs and has full Unicode support, but removes non-standard extensions of the old parser, which could break code: - String concatenation: the old parser concatenated adjacent string literals like C does. - Comments: the old parser supported C and C++-style comments. JSON doesn't allow comments.
Removing support for comments did break something. Unfortunately there was no sign of this in the release notes, so I had to debug it the hard way (in code that swallowed the exception from the parser - gah!) and only found the commit message once I already knew what the problem was.
</rant>
On 9/10/2015 12:26 PM, Jonathan Wakely wrote:
On 10 September 2015 at 07:47, Viktor Sehr wrote:
Same thing happened to me, suddenly my application stopped to work. I really think it should accept comments.
A parser option to allow/disallow comments would be nice, but at a minimum the breaking change should be documented in the release notes, not buried away in git commit logs.
I totally agree with this. Any breaking change to a library should go into the release notes at the least. IMO it should also be emphatically mentioned in the docs of that library also.
/Viktor
On Wed, Sep 2, 2015 at 7:18 PM Jonathan Wakely <jwakely.boost@kayari.org> wrote:
The commit logs say:
TL;DR: The new parser fixes long-standing bugs and has full Unicode support, but removes non-standard extensions of the old parser, which could break code: - String concatenation: the old parser concatenated adjacent string literals like C does. - Comments: the old parser supported C and C++-style comments. JSON doesn't allow comments.
Removing support for comments did break something. Unfortunately there was no sign of this in the release notes, so I had to debug it the hard way (in code that swallowed the exception from the parser - gah!) and only found the commit message once I already knew what the problem was.
</rant>
On 11-Sep-15 12:14 AM, Edward Diener wrote:
On 9/10/2015 12:26 PM, Jonathan Wakely wrote:
On 10 September 2015 at 07:47, Viktor Sehr wrote:
Same thing happened to me, suddenly my application stopped to work. I really think it should accept comments.
A parser option to allow/disallow comments would be nice, but at a minimum the breaking change should be documented in the release notes, not buried away in git commit logs.
I totally agree with this. Any breaking change to a library should go into the release notes at the least. IMO it should also be emphatically mentioned in the docs of that library also.
If anybody in this thread can produce a wording for release notes, and create a pull request for website, that would be great. Alternatively, just product a wording, and I can get it included. Obviously, as far as library documentation and support for JSON comments, you'd need to ping library maintainer. Thanks, Volodya
On 11 September 2015 at 20:08, Vladimir Prus wrote:
On 11-Sep-15 12:14 AM, Edward Diener wrote:
On 9/10/2015 12:26 PM, Jonathan Wakely wrote:
On 10 September 2015 at 07:47, Viktor Sehr wrote:
Same thing happened to me, suddenly my application stopped to work. I really think it should accept comments.
A parser option to allow/disallow comments would be nice, but at a minimum the breaking change should be documented in the release notes, not buried away in git commit logs.
I totally agree with this. Any breaking change to a library should go into the release notes at the least. IMO it should also be emphatically mentioned in the docs of that library also.
If anybody in this thread can produce a wording for release notes, and create a pull request for website, that would be great. Alternatively, just product a wording, and I can get it included.
Sure, here you go: https://github.com/boostorg/website/pull/100 Thanks.
participants (4)
-
Edward Diener -
Jonathan Wakely -
Viktor Sehr -
Vladimir Prus