First off a big thanks to all the folks who participated in the review process, and of course to Matt and Chris for submitting the library. Then the headline news: with 8 favorable reviews, and two equivocal ones, Boost.Decimal is ACCEPTED into Boost. There were two main contentious issues: 1) Cohort support: several reviewers asked for cohort support and one thought that printing the actual cohort should be the default. I know that Matt has been working on support for cohort IO, on the basis that the notion of cohorts take some getting used to, and that libraries should generally make the easy stuff easy, I' happy for this to NOT be the default. 2) Binary-decimal conversion. This was discussed in some depth during the review, so I won't try to repeat here. Matt has agreed to document the issue, and to make binary-decimal conversion non-straightforward (ie strongly discouraged), I'm also satisfied that the interface can be extended (in a non-breaking way) to support multiple conversion methods at a later date should there prove to be demand. Given the difficulty of implementing those methods correctly, this sounds like a reasonable compromise to me at present. I've filed all the issues raised by reviewers as issues so folks can track their progress, they are: * Cohort IO support: https://github.com/cppalliance/decimal/issues/1218 * Document what a normalized number is: https://github.com/cppalliance/decimal/issues/1217 * Document samequantum behavior: https://github.com/cppalliance/decimal/issues/1216 * Do we need issignalling, is the signature correct: https://github.com/cppalliance/decimal/issues/1215 * Better document {fmt} support: https://github.com/cppalliance/decimal/issues/1214 * Financial examples need explanatory text: https://github.com/cppalliance/decimal/issues/1213 * Document what bit conversion do: https://github.com/cppalliance/decimal/issues/1212 * Explain generic programming example, remove/rename float_equal function: https://github.com/cppalliance/decimal/issues/1211 * Improve charconv docs: https://github.com/cppalliance/decimal/issues/1210 * Clean up badly named "promotion" section in the docs: https://github.com/cppalliance/decimal/issues/1209 * Improve literal docs (and float_equal again): https://github.com/cppalliance/decimal/issues/1208 * Improve construction docs: https://github.com/cppalliance/decimal/issues/1207 * Improve examples with better hand holding rather than bare code: https://github.com/cppalliance/decimal/issues/1206 * Improve readability of binary constants: https://github.com/cppalliance/decimal/issues/1205 * Probably remove the bitwise operators: https://github.com/cppalliance/decimal/issues/1204 * Simplify numeric_limits, provide out-of-line data members: https://github.com/cppalliance/decimal/issues/1203 * Misc doc typos and corrections: https://github.com/cppalliance/decimal/issues/1202 * Correct <format> detection: https://github.com/cppalliance/decimal/issues/1201 * {fmt} unicode support: https://github.com/cppalliance/decimal/issues/1200 * Arm64 detection: https://github.com/cppalliance/decimal/issues/1199 * Codecov markup: https://github.com/cppalliance/decimal/issues/1198 * assert in charconv example: https://github.com/cppalliance/decimal/issues/1197 * Improve example descriptions: https://github.com/cppalliance/decimal/issues/1196 * More precise header usage in examples: https://github.com/cppalliance/decimal/issues/1195 * Public to_string function is undocumented: https://github.com/cppalliance/decimal/issues/1194 * Mistaken using declaration in docs (make the documentation code runable as part of the tests): https://github.com/cppalliance/decimal/issues/1193 * Testing only code in public headers: https://github.com/cppalliance/decimal/issues/1192 * charconv docs do not compile (T undefined):https://github.com/cppalliance/decimal/issues/1191 * Binary - decimal conversions: https://github.com/cppalliance/decimal/issues/1188 * Convenience string constructors: https://github.com/cppalliance/decimal/issues/1187 * Make sure decTest tests pass: https://github.com/cppalliance/decimal/issues/1186 * Rounding docs: https://github.com/cppalliance/decimal/issues/1185 Once again, many thanks to everyone involved, best, John.
Then the headline news: with 8 favorable reviews, and two equivocal ones, Boost.Decimal is ACCEPTED into Boost.
Thank you John for managing the review twice, and tracking the numerous issues and contention points. Also thank you to all the reviewers from both review periods. The library definitely got better each time. Matt
El 10/11/2025 a las 14:54, John Maddock via Boost escribió:
First off a big thanks to all the folks who participated in the review process, and of course to Matt and Chris for submitting the library.
Then the headline news: with 8 favorable reviews, and two equivocal ones, Boost.Decimal is ACCEPTED into Boost.
Congrats Matt and Chris! And many thanks John for your great work as review manager. Best, Ion
On Monday, November 10, 2025, John Maddock wrote:
Then the headline news: with 8 favorable reviews, and two equivocal ones, Boost.Decimal is ACCEPTED into Boost.
Congratulations Matt, Chris and thank you for contributing Decimal to Boost. And thank you John for managing the review. Glen
> Then the headline news: with 8 favorable reviews,> and two equivocal ones, Boost.Decimal is ACCEPTED> into Boost.
Thank you John for managing the reviewand the re-review.
Thank you to all the participants.
- Chris
On Monday, November 10, 2025 at 02:55:25 PM GMT+1, John Maddock via Boost <boost@lists.boost.org> wrote:
First off a big thanks to all the folks who participated in the review
process, and of course to Matt and Chris for submitting the library.
Then the headline news: with 8 favorable reviews, and two equivocal
ones, Boost.Decimal is ACCEPTED into Boost.
There were two main contentious issues:
1) Cohort support: several reviewers asked for cohort support and one
thought that printing the actual cohort should be the default. I know
that Matt has been working on support for cohort IO, on the basis that
the notion of cohorts take some getting used to, and that libraries
should generally make the easy stuff easy, I' happy for this to NOT be
the default.
2) Binary-decimal conversion. This was discussed in some depth during
the review, so I won't try to repeat here. Matt has agreed to document
the issue, and to make binary-decimal conversion non-straightforward (ie
strongly discouraged), I'm also satisfied that the interface can be
extended (in a non-breaking way) to support multiple conversion methods
at a later date should there prove to be demand. Given the difficulty
of implementing those methods correctly, this sounds like a reasonable
compromise to me at present.
I've filed all the issues raised by reviewers as issues so folks can
track their progress, they are:
* Cohort IO support: https://github.com/cppalliance/decimal/issues/1218
* Document what a normalized number is:
https://github.com/cppalliance/decimal/issues/1217
* Document samequantum behavior:
https://github.com/cppalliance/decimal/issues/1216
* Do we need issignalling, is the signature correct:
https://github.com/cppalliance/decimal/issues/1215
* Better document {fmt} support:
https://github.com/cppalliance/decimal/issues/1214
* Financial examples need explanatory text:
https://github.com/cppalliance/decimal/issues/1213
* Document what bit conversion do:
https://github.com/cppalliance/decimal/issues/1212
* Explain generic programming example, remove/rename float_equal
function: https://github.com/cppalliance/decimal/issues/1211
* Improve charconv docs: https://github.com/cppalliance/decimal/issues/1210
* Clean up badly named "promotion" section in the docs:
https://github.com/cppalliance/decimal/issues/1209
* Improve literal docs (and float_equal again):
https://github.com/cppalliance/decimal/issues/1208
* Improve construction docs:
https://github.com/cppalliance/decimal/issues/1207
* Improve examples with better hand holding rather than bare code:
https://github.com/cppalliance/decimal/issues/1206
* Improve readability of binary constants:
https://github.com/cppalliance/decimal/issues/1205
* Probably remove the bitwise operators:
https://github.com/cppalliance/decimal/issues/1204
* Simplify numeric_limits, provide out-of-line data members:
https://github.com/cppalliance/decimal/issues/1203
* Misc doc typos and corrections:
https://github.com/cppalliance/decimal/issues/1202
* Correct <format> detection:
https://github.com/cppalliance/decimal/issues/1201
* {fmt} unicode support: https://github.com/cppalliance/decimal/issues/1200
* Arm64 detection: https://github.com/cppalliance/decimal/issues/1199
* Codecov markup: https://github.com/cppalliance/decimal/issues/1198
* assert in charconv example:
https://github.com/cppalliance/decimal/issues/1197
* Improve example descriptions:
https://github.com/cppalliance/decimal/issues/1196
* More precise header usage in examples:
https://github.com/cppalliance/decimal/issues/1195
* Public to_string function is undocumented:
https://github.com/cppalliance/decimal/issues/1194
* Mistaken using declaration in docs (make the documentation code
runable as part of the tests):
https://github.com/cppalliance/decimal/issues/1193
* Testing only code in public headers:
https://github.com/cppalliance/decimal/issues/1192
* charconv docs do not compile (T
undefined):https://github.com/cppalliance/decimal/issues/1191
* Binary - decimal conversions:
https://github.com/cppalliance/decimal/issues/1188
* Convenience string constructors:
https://github.com/cppalliance/decimal/issues/1187
* Make sure decTest tests pass:
https://github.com/cppalliance/decimal/issues/1186
* Rounding docs: https://github.com/cppalliance/decimal/issues/1185
Once again, many thanks to everyone involved, best, John.
_______________________________________________
Boost mailing list -- boost@lists.boost.org
To unsubscribe send an email to boost-leave@lists.boost.org
https://lists.boost.org/mailman3/lists/boost.lists.boost.org/
Archived at: https://lists.boost.org/archives/list/boost@lists.boost.org/message/F5FIMGM7CCC24OKQZEFMHHSUV64XX63I/
participants (5)
-
Christopher Kormanyos -
Glen Fernandes -
Ion Gaztañaga -
John Maddock -
Matt Borland