Hi all, I recently pushed something for boost.test on develop that is apparently breaking the builds on mingw: http://www.boost.org/development/tests/develop/developer/output/igaztanaga-d... What I do in the code is this: ---------- #ifdef _WIN32 #include <Windows.h> #endif ---------- and then later ---------- #ifdef _WIN32 class setcolor { protected: void set_console_color(std::ostream& os, WORD *attributes = NULL) const { DWORD console_type; /// some additional windows specific code #endif ---------- I thought that this would be enough for having the windows specific code, but apparently mingw disagrees with the error that some windows specific define is not there. Is this an issue with the code, the SDK, the machine? I have no experience with mingw, but if we are able to include windows.h, then we have to have the defines there (the missing macro is there since Windows 2000). Thanks for the help, Raffi
Hi Raffi,
-----Original Message----- From: Boost [mailto:boost-bounces@lists.boost.org] On Behalf Of Raffi Enficiaud via Boost Sent: Mittwoch, 17. Januar 2018 20:42 To: boost@lists.boost.org Cc: Raffi Enficiaud <raffi.enficiaud@mines-paris.org> Subject: [boost] mingw and windows.h
I recently pushed something for boost.test on develop that is apparently breaking the builds on mingw: http://www.boost.org/development/tests/develop/developer/output/igazt anaga-develop-gcc-4-2c++03-boost-bin-v2-libs-test-test-version-uses- module-name-test-gcc-4-2c+-dbg-dbg-symbl-off.html [...] I thought that this would be enough for having the windows specific code, but apparently mingw disagrees with the error that some windows specific define is not there.
Is this an issue with the code, the SDK, the machine? I have no experience with mingw, but if we are able to include windows.h, then we have to have the defines there (the missing macro is there since Windows 2000).
original MinGW is missing that define (and many more) completely, it should be in wincon.h: https://sourceforge.net/p/mingw/mingw-org-wsl/ci/5.1-trunk/tree/w32api/inclu... MinGW-w64 has it. Marcel
Le 17.01.18 à 21:39, Marcel Raad via Boost a écrit :
Hi Raffi,
[snip]
original MinGW is missing that define (and many more) completely, it should be in wincon.h: https://sourceforge.net/p/mingw/mingw-org-wsl/ci/5.1-trunk/tree/w32api/inclu...
MinGW-w64 has it.
Marcel
Thanks for the reply. I did not know that mingw was mimicking platform headers. I guess that using the macro __MINGW32__ is the way to fix those issues, right? Thanks, Raffi
-----Original Message----- From: Boost [mailto:boost-bounces@lists.boost.org] On Behalf Of Raffi Enficiaud via Boost Sent: Donnerstag, 18. Januar 2018 08:49 To: boost@lists.boost.org Cc: Raffi Enficiaud <raffi.enficiaud@mines-paris.org> Subject: Re: [boost] mingw and windows.h
I guess that using the macro __MINGW32__ is the way to fix those issues, right?
That would detect both original MinGW and MinGW-w64, you probably want a workaround for only mingw.org MinGW. Boost.Predef distinguishes between the two: https://github.com/boostorg/predef/commit/7c17b932e4ac9d33272c91cfb45d7cff99... Marcel
-----Original Message----- From: Boost [mailto:boost-bounces@lists.boost.org] On Behalf Of Marcel Raad via Boost Sent: 17 January 2018 20:40 To: boost@lists.boost.org Cc: Marcel Raad; Raffi Enficiaud Subject: Re: [boost] mingw and windows.h
Hi Raffi,
-----Original Message----- From: Boost [mailto:boost-bounces@lists.boost.org] On Behalf Of Raffi Enficiaud via Boost Sent: Mittwoch, 17. Januar 2018 20:42 To: boost@lists.boost.org Cc: Raffi Enficiaud <raffi.enficiaud@mines-paris.org> Subject: [boost] mingw and windows.h
I recently pushed something for boost.test on develop that is apparently breaking the builds on mingw: http://www.boost.org/development/tests/develop/developer/output/igazt anaga-develop-gcc-4-2c++03-boost-bin-v2-libs-test-test-version-uses- module-name-test-gcc-4-2c+-dbg-dbg-symbl-off.html [...] I thought that this would be enough for having the windows specific code, but apparently mingw disagrees with the error that some windows specific define is not there.
Is this an issue with the code, the SDK, the machine? I have no experience with mingw, but if we are able to include windows.h, then we have to have the defines there (the missing macro is there since Windows 2000).
original MinGW is missing that define (and many more) completely, it should be in wincon.h: https://sourceforge.net/p/mingw/mingw-org-wsl/ci/5.1-trunk/tree/w32api/inclu...
MinGW-w64 has it.
In my experience, MinGW-W64 is the way forward. It is being maintained and enhanced. Paul --- Paul A. Bristow Prizet Farmhouse Kendal UK LA8 8AB +44 (0) 1539 561830
participants (3)
-
Marcel Raad -
Paul A. Bristow -
Raffi Enficiaud