Request to fix docs mistake in Boost.Outcome
I know the beta release is happening, but when it's out and master branch is reopened can I get permission to merge a mistake in documentation fixed by https://github.com/ned14/outcome/issues/280? Niall
On Thu, Jul 13, 2023 at 6:04 AM Niall Douglas via Boost <boost@lists.boost.org> wrote:
I know the beta release is happening, but when it's out and master branch is reopened can I get permission to merge a mistake in documentation fixed by https://github.com/ned14/outcome/issues/280?
I thought documentation changes were unpermissioned and all-you-can-eat? Thanks
On 13/07/2023 14:16, Vinnie Falco wrote:
On Thu, Jul 13, 2023 at 6:04 AM Niall Douglas via Boost <boost@lists.boost.org> wrote:
I know the beta release is happening, but when it's out and master branch is reopened can I get permission to merge a mistake in documentation fixed by https://github.com/ned14/outcome/issues/280?
I thought documentation changes were unpermissioned and all-you-can-eat?
Marshall has gotten annoyed with me in the past for changing the Outcome root SHA without telling him first, so now I tell him first. Niall
On Jul 13, 2023, at 6:20 AM, Niall Douglas via Boost <boost@lists.boost.org> wrote:
On 13/07/2023 14:16, Vinnie Falco wrote:
On Thu, Jul 13, 2023 at 6:04 AM Niall Douglas via Boost <boost@lists.boost.org> wrote:
I know the beta release is happening, but when it's out and master branch is reopened can I get permission to merge a mistake in documentation fixed by https://github.com/ned14/outcome/issues/280?
I thought documentation changes were unpermissioned and all-you-can-eat?
Marshall has gotten annoyed with me in the past for changing the Outcome root SHA without telling him first, so now I tell him first.
Marshall would like to believe :-) that he hasn’t been annoyed about doc fixes in the past. — Marshall P.S. I recall objecting to a set of changes that included doc fixes as well as other stuff.
On 13/07/2023 14:45, Marshall Clow wrote:
On Jul 13, 2023, at 6:20 AM, Niall Douglas via Boost <boost@lists.boost.org> wrote:
On 13/07/2023 14:16, Vinnie Falco wrote:
On Thu, Jul 13, 2023 at 6:04 AM Niall Douglas via Boost <boost@lists.boost.org> wrote:
I know the beta release is happening, but when it's out and master branch is reopened can I get permission to merge a mistake in documentation fixed by https://github.com/ned14/outcome/issues/280?
I thought documentation changes were unpermissioned and all-you-can-eat?
Marshall has gotten annoyed with me in the past for changing the Outcome root SHA without telling him first, so now I tell him first.
Marshall would like to believe :-) that he hasn’t been annoyed about doc fixes in the past.
— Marshall
P.S. I recall objecting to a set of changes that included doc fixes as well as other stuff.
Correct. Has master branch reopened for merge now the beta is out? Niall
On Jul 14, 2023, at 2:27 AM, Niall Douglas via Boost <boost@lists.boost.org> wrote:
On 13/07/2023 14:45, Marshall Clow wrote:
On Jul 13, 2023, at 6:20 AM, Niall Douglas via Boost <boost@lists.boost.org> wrote:
On 13/07/2023 14:16, Vinnie Falco wrote:
On Thu, Jul 13, 2023 at 6:04 AM Niall Douglas via Boost <boost@lists.boost.org> wrote:
I know the beta release is happening, but when it's out and master branch is reopened can I get permission to merge a mistake in documentation fixed by https://github.com/ned14/outcome/issues/280?
I thought documentation changes were unpermissioned and all-you-can-eat?
Marshall has gotten annoyed with me in the past for changing the Outcome root SHA without telling him first, so now I tell him first.
Marshall would like to believe :-) that he hasn’t been annoyed about doc fixes in the past.
— Marshall
P.S. I recall objecting to a set of changes that included doc fixes as well as other stuff.
Correct.
Has master branch reopened for merge now the beta is out?
Yes it has. — Marshall
On 14/07/2023 16:05, Marshall Clow via Boost wrote:
Has master branch reopened for merge now the beta is out?
Yes it has.
Excellent. Can I get permission to merge a few small bug fixes plus docs fixes? https://github.com/boostorg/outcome/commits/develop 1. Changes just before the beta window breaks build on C++ 14 in certain corner cases, fixed. 2. Experimental Outcome Boost result did not compile due to changes to status code by LEWG, fixed. 3. Docs fixes also due to the LEWG renaming breaking docs examples. Niall
On Jul 15, 2023, at 2:56 PM, Niall Douglas via Boost <boost@lists.boost.org> wrote:
On 14/07/2023 16:05, Marshall Clow via Boost wrote:
Has master branch reopened for merge now the beta is out?
Yes it has.
Excellent.
Can I get permission to merge a few small bug fixes plus docs fixes?
https://github.com/boostorg/outcome/commits/develop
1. Changes just before the beta window breaks build on C++ 14 in certain corner cases, fixed.
2. Experimental Outcome Boost result did not compile due to changes to status code by LEWG, fixed.
3. Docs fixes also due to the LEWG renaming breaking docs examples.
Go ahead. — Marshall
On 7/13/23 16:20, Niall Douglas via Boost wrote:
On 13/07/2023 14:16, Vinnie Falco wrote:
On Thu, Jul 13, 2023 at 6:04 AM Niall Douglas via Boost <boost@lists.boost.org> wrote:
I know the beta release is happening, but when it's out and master branch is reopened can I get permission to merge a mistake in documentation fixed by https://github.com/ned14/outcome/issues/280?
I thought documentation changes were unpermissioned and all-you-can-eat?
Marshall has gotten annoyed with me in the past for changing the Outcome root SHA without telling him first, so now I tell him first.
I believe, there is a time frame during archive preparation when *no* changes to master are permitted. Other than that, changes to docs don't need a permission.
participants (4)
-
Andrey Semashev -
Marshall Clow -
Niall Douglas -
Vinnie Falco