[UUID] uuid.hpp ODR violation and Ctrl-M pollution
Hi all, Using "uuid_alt_v13_pod.zip": 1) It seems that some namespace function definitions in uuid.hpp violate the ODR, specifically the ones lacking inline keyword. This is one of the errors I get using Apple's g++-4.0 when including uuid.hpp in two different source files: ld: duplicate symbol boost::uuids::operator>=(boost::uuids::uuid const&, boost::uuids::uuid const&) If I add inline to the aforementioned function definitions, then the linker errors go away, which makes since. After some digging around, this issue was discussed beginning with: http://lists.boost.org/Archives/boost/2007/05/122479.php but seems to have cropped back up. Examples are: "uuid/boost/uuid/uuid_io.hpp" and the files under "uuid/libs/uuid/test/"2) Also some files in the package are pseudo-randomly sprinkled with Ctrl-M characters, as if someone edited them with two different editors.. -Mostafa
Mostafa wrote:
Examples are: "uuid/boost/uuid/uuid_io.hpp" and the files under "uuid/libs/uuid/test/"2) Also some files in the package are pseudo-randomly sprinkled with Ctrl-M characters, as if someone edited them with two different editors..
The above paragraph should have read: 2) Also some files in the package are pseudo-randomly sprinkled with Ctrl-M characters, as if someone edited them with two different editors. Examples are: "uuid/boost/uuid/uuid_io.hpp" and the files under "uuid/libs/uuid/test/". Excuse the dyslexia.
2009/8/20 Mostafa <mostafa_working_away@yahoo.com>:
Using "uuid_alt_v13_pod.zip":
1) It seems that some namespace function definitions in uuid.hpp violate the ODR, specifically the ones lacking inline keyword.
Quite plausible.
2) Also some files in the package are pseudo-randomly sprinkled with Ctrl-M characters, as if someone edited them with two different editors. Examples are: "uuid/boost/uuid/uuid_io.hpp" and the files under "uuid/libs/uuid/test/".
That's exactly what happened. That zip is one I threw together fairly quickly to demonstrate my proposed interface changes, not something that I would consider review-ready. I don't know what the current status is. Here an excerpt from an email from Andy on April 9: "I am working on getting it into boost. I did hope to to get it into 1.39.0, but sadly this won't happen. I need to finish going through the post from the review and ensure I have addressed all of them."
On Thu, 20 Aug 2009 10:46:14 -0700, Scott McMurray <me22.ca+boost@gmail.com> wrote: ...
I don't know what the current status is. Here an excerpt from an email from Andy on April 9: "I am working on getting it into boost. I did hope to to get it into 1.39.0, but sadly this won't happen. I need to finish going through the post from the review and ensure I have addressed all of them." ...
If I encounter further issues should I still report them here?
On Thu, 20 Aug 2009 10:46 -0700, "Scott McMurray" <me22.ca+boost@gmail.com> wrote:
2009/8/20 Mostafa <mostafa_working_away@yahoo.com>:
Using "uuid_alt_v13_pod.zip":
1) It seems that some namespace function definitions in uuid.hpp violate the ODR, specifically the ones lacking inline keyword.
Quite plausible.
I will check my version that will go into boost.
2) Also some files in the package are pseudo-randomly sprinkled with Ctrl-M characters, as if someone edited them with two different editors. Examples are: "uuid/boost/uuid/uuid_io.hpp" and the files under "uuid/libs/uuid/test/".
That's exactly what happened. That zip is one I threw together fairly quickly to demonstrate my proposed interface changes, not something that I would consider review-ready.
I don't know what the current status is. Here an excerpt from an email from Andy on April 9: "I am working on getting it into boost. I did hope to to get it into 1.39., but sadly this won't happen. I need to finish going through the post from the review and ensure I have addressed all of them."
I am continuing to work on getting the uuid library into boost. Thank you to everyone for being so patient with me. Regards, Andy.
participants (3)
-
Andy Tompkins -
Mostafa -
Scott McMurray