patch for Intel compiler for new lib appeared in boost 1.65 beta
Hi, I am Vasiliy Kurkov and I'm working as QA engineer in Intel Compiler QA team. I have tried to build boost libs from 1.65 beta, but I faced the following issue on Windows for new stacktrace lib: compile-c-c++ bin.v2\libs\stacktrace\build\07984f9e4da2f3b833f7520e2f16f320\windbg_cached.obj icl @"bin.v2\libs\stacktrace\build\07984f9e4da2f3b833f7520e2f16f320\windbg_cached.obj.rsp" windbg_cached.cpp .\boost/stacktrace/detail/collect_unwind.ipp(17): catastrophic error: cannot open source file "unwind.h" #include <unwind.h> ^ compilation aborted for libs\stacktrace\build\..\src\windbg_cached.cpp (code 4) Environment: Windows 2016 Server + MSVS2017 + Intel Compiler 17.0 or later I would like to suggested the following patch: --- 1/boost_1_65_0/boost/stacktrace/safe_dump_to.hpp 2017-08-16 13:37:10.003950000 +0300 +++ 2/boost_1_65_0/boost/stacktrace/safe_dump_to.hpp 2017-08-16 13:38:05.470305000 +0300 @@ -203,7 +203,7 @@ # else # include <boost/stacktrace/detail/safe_dump_posix.ipp> # endif -# if defined(BOOST_MSVC) +# if defined(BOOST_MSVC) || defined(BOOST_INTEL) # include <boost/stacktrace/detail/collect_msvc.ipp> # else # include <boost/stacktrace/detail/collect_unwind.ipp> Thank you in advance. -- Regards, Vasiliy -------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.
On 08/16/17 17:28, Kurkov, Vasiliy A via Boost wrote:
Hi,
I am Vasiliy Kurkov and I'm working as QA engineer in Intel Compiler QA team.
I have tried to build boost libs from 1.65 beta, but I faced the following issue on Windows for new stacktrace lib:
compile-c-c++ bin.v2\libs\stacktrace\build\07984f9e4da2f3b833f7520e2f16f320\windbg_cached.obj
icl @"bin.v2\libs\stacktrace\build\07984f9e4da2f3b833f7520e2f16f320\windbg_cached.obj.rsp"
windbg_cached.cpp .\boost/stacktrace/detail/collect_unwind.ipp(17): catastrophic error: cannot open source file "unwind.h" #include <unwind.h> ^
compilation aborted for libs\stacktrace\build\..\src\windbg_cached.cpp (code 4)
Environment: Windows 2016 Server + MSVS2017 + Intel Compiler 17.0 or later
I would like to suggested the following patch:
--- 1/boost_1_65_0/boost/stacktrace/safe_dump_to.hpp 2017-08-16 13:37:10.003950000 +0300 +++ 2/boost_1_65_0/boost/stacktrace/safe_dump_to.hpp 2017-08-16 13:38:05.470305000 +0300 @@ -203,7 +203,7 @@ # else # include <boost/stacktrace/detail/safe_dump_posix.ipp> # endif -# if defined(BOOST_MSVC) +# if defined(BOOST_MSVC) || defined(BOOST_INTEL) # include <boost/stacktrace/detail/collect_msvc.ipp> # else # include <boost/stacktrace/detail/collect_unwind.ipp>
Thank you in advance.
BOOST_INTEL is defined both on Windows and Linux, and I suspect collect_msvc.ipp is Windows-specific. You might want to check for BOOST_INTEL_WIN. Also, patches are typically posted as PRs.
2017-08-16 14:28 GMT+00:00 Kurkov, Vasiliy A via Boost <boost@lists.boost.org>:
Hi,
I am Vasiliy Kurkov and I'm working as QA engineer in Intel Compiler QA team.
I have tried to build boost libs from 1.65 beta, but I faced the following issue on Windows for new stacktrace lib: <...>
Thanks for the issue report! That issue was fixed https://github.com/boostorg/stacktrace/commit/b931f501d116fe71a878beaffca886... and now the library works well on Intel compilers.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.
Please clarify, who are the intended recipients. -- Best regards, Antony Polukhin
Antony, Thank you for the quick fix.
Please clarify, who are the intended recipients.
Intended recipients are subscribers of the boost@lists.boost.org mail list. -- Regards, Vasiliy -----Original Message----- From: Boost [mailto:boost-bounces@lists.boost.org] On Behalf Of Antony Polukhin via Boost Sent: Thursday, August 17, 2017 7:43 AM To: boost@lists.boost.org List <boost@lists.boost.org> Cc: Antony Polukhin <antoshkka@gmail.com> Subject: Re: [boost] patch for Intel compiler for new lib appeared in boost 1.65 beta 2017-08-16 14:28 GMT+00:00 Kurkov, Vasiliy A via Boost <boost@lists.boost.org>:
Hi,
I am Vasiliy Kurkov and I'm working as QA engineer in Intel Compiler QA team.
I have tried to build boost libs from 1.65 beta, but I faced the following issue on Windows for new stacktrace lib: <...>
Thanks for the issue report! That issue was fixed https://github.com/boostorg/stacktrace/commit/b931f501d116fe71a878beaffca886... and now the library works well on Intel compilers.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.
Please clarify, who are the intended recipients. -- Best regards, Antony Polukhin _______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost -------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.
participants (3)
-
Andrey Semashev -
Antony Polukhin -
Kurkov, Vasiliy A