[thread] Mass test failures on clang
Hi, I'm seeing mass test failures in Atomic and Log both in develop and master. E.g.: http://www.boost.org/development/tests/develop/developer/atomic.html http://www.boost.org/development/tests/master/developer/atomic.html The logs are not descriptive (as usual) but point to Thread compilation: http://www.boost.org/development/tests/develop/developer/output/teeks99-04b-... Could this be resolved? The freeze deadline is nearing, so I'd like to see my test results at least once before it is reached.
Le 09/06/14 12:25, Andrey Semashev a écrit :
Hi,
I'm seeing mass test failures in Atomic and Log both in develop and master. E.g.:
http://www.boost.org/development/tests/develop/developer/atomic.html http://www.boost.org/development/tests/master/developer/atomic.html
The logs are not descriptive (as usual) but point to Thread compilation:
http://www.boost.org/development/tests/develop/developer/output/teeks99-04b-...
Could this be resolved? The freeze deadline is nearing, so I'd like to see my test results at least once before it is reached.
I would like to, but with the following log, I'm unable to :( Vicente Test output: boost/bin.v2/libs/thread/build/clang-linux-3.4/debug/threading-multi Rev b932921a8ebf5d42337f0b48f46ac77b072f35e7 / Sun, 08 Jun 2014 17:24:48 +0000 Compile [2014-06-08 21:05:30 UTC]: succeed "clang++-3.4" -c -x c++ -Wextra -Wno-long-long -Wno-variadic-macros -Wunused-function -pedantic -O0 -g -fno-inline -Wall -pedantic -g -pthread -fPIC -Wextra -Wno-long-long -Wno-variadic-macros -Wunused-function -pedantic -DBOOST_ALL_NO_LIB=1 -DBOOST_SYSTEM_DYN_LINK=1 -DBOOST_THREAD_BUILD_DLL=1 -DBOOST_THREAD_DONT_USE_CHRONO -DBOOST_THREAD_POSIX -I".." -o "/home/tomkent/teeks99-04/b/results/boost/bin.v2/libs/thread/build/clang-linux-3.4/debug/threading-multi/future.o" "../libs/thread/src/future.cpp"
Le 09/06/14 12:49, Vicente J. Botet Escriba a écrit :
Le 09/06/14 12:25, Andrey Semashev a écrit :
Hi,
I'm seeing mass test failures in Atomic and Log both in develop and master. E.g.:
http://www.boost.org/development/tests/develop/developer/atomic.html http://www.boost.org/development/tests/master/developer/atomic.html
The logs are not descriptive (as usual) but point to Thread compilation:
http://www.boost.org/development/tests/develop/developer/output/teeks99-04b-...
Could this be resolved? The freeze deadline is nearing, so I'd like to see my test results at least once before it is reached.
I would like to, but with the following log, I'm unable to :(
Vicente
Test output: boost/bin.v2/libs/thread/build/clang-linux-3.4/debug/threading-multi Rev b932921a8ebf5d42337f0b48f46ac77b072f35e7 / Sun, 08 Jun 2014 17:24:48 +0000 Compile [2014-06-08 21:05:30 UTC]: succeed "clang++-3.4" -c -x c++ -Wextra -Wno-long-long -Wno-variadic-macros -Wunused-function -pedantic -O0 -g -fno-inline -Wall -pedantic -g -pthread -fPIC -Wextra -Wno-long-long -Wno-variadic-macros -Wunused-function -pedantic -DBOOST_ALL_NO_LIB=1 -DBOOST_SYSTEM_DYN_LINK=1 -DBOOST_THREAD_BUILD_DLL=1 -DBOOST_THREAD_DONT_USE_CHRONO -DBOOST_THREAD_POSIX -I".." -o "/home/tomkent/teeks99-04/b/results/boost/bin.v2/libs/thread/build/clang-linux-3.4/debug/threading-multi/future.o" "../libs/thread/src/future.cpp"
Otherwise, I know why the following is failing http://www.boost.org/development/tests/develop/developer/output/jasonr-Ubunt... ../boost/thread/future.hpp(3561): error: no suitable conversion function from "boost::launch" to "int" exists if (int(policy) & int(launch::async)) { ^ ../boost/thread/future.hpp(3567): error: no suitable conversion function from "boost::launch" to "int" exists } else if (int(policy) & int(launch::deferred)) { ^ ../boost/thread/future.hpp(3626): error: no suitable conversion function from "boost::launch" to "int" exists if (int(policy) & int(launch::async)) { ^ ../boost/thread/future.hpp(3632): error: no suitable conversion function from "boost::launch" to "int" exists } else if (int(policy) & int(launch::deferred)) { Vicente
On Monday 09 June 2014 12:53:31 Vicente J. Botet Escriba wrote:
Le 09/06/14 12:49, Vicente J. Botet Escriba a écrit :
Le 09/06/14 12:25, Andrey Semashev a écrit :
Hi,
I'm seeing mass test failures in Atomic and Log both in develop and master. Otherwise, I know why the following is failing
http://www.boost.org/development/tests/develop/developer/output/jasonr-Ubunt u13-10-intel-12-1-6-boost-bin-v2-libs-thread-test-async__async_p-test-intel- linux-12-1-6-debug-threading-multi.html
../boost/thread/future.hpp(3561): error: no suitable conversion function from "boost::launch" to "int" exists if (int(policy) & int(launch::async)) { ^
../boost/thread/future.hpp(3567): error: no suitable conversion function from "boost::launch" to "int" exists } else if (int(policy) & int(launch::deferred)) { ^
../boost/thread/future.hpp(3626): error: no suitable conversion function from "boost::launch" to "int" exists if (int(policy) & int(launch::async)) { ^
../boost/thread/future.hpp(3632): error: no suitable conversion function from "boost::launch" to "int" exists } else if (int(policy) & int(launch::deferred)) {
The changes you made seem to have helped in develop, thanks. Could you merge them to master?
Le 13/06/14 10:01, Andrey Semashev a écrit :
On Monday 09 June 2014 12:53:31 Vicente J. Botet Escriba wrote:
Le 09/06/14 12:49, Vicente J. Botet Escriba a écrit :
Le 09/06/14 12:25, Andrey Semashev a écrit : The changes you made seem to have helped in develop, thanks. Could you merge them to master?
Yes, I will do today. Vicente
On Monday 09 June 2014 12:49:30 Vicente J. Botet Escriba wrote:
Le 09/06/14 12:25, Andrey Semashev a écrit :
Hi,
I'm seeing mass test failures in Atomic and Log both in develop and master. E.g.:
http://www.boost.org/development/tests/develop/developer/atomic.html http://www.boost.org/development/tests/master/developer/atomic.html
The logs are not descriptive (as usual) but point to Thread compilation:
http://www.boost.org/development/tests/develop/developer/output/teeks99-04 b-Ubuntu12-04-64-boost-bin-v2-libs-log-test-attr_attribute_set-test-clang- linux-3-4-debug-threading-multi.html
Could this be resolved? The freeze deadline is nearing, so I'd like to see my test results at least once before it is reached.
I would like to, but with the following log, I'm unable to :(
Vicente
Test output: boost/bin.v2/libs/thread/build/clang-linux-3.4/debug/threading-multi Rev b932921a8ebf5d42337f0b48f46ac77b072f35e7 / Sun, 08 Jun 2014 17:24:48 +0000 Compile [2014-06-08 21:05:30 UTC]: succeed
"clang++-3.4" -c -x c++ -Wextra -Wno-long-long -Wno-variadic-macros -Wunused-function -pedantic -O0 -g -fno-inline -Wall -pedantic -g -pthread -fPIC -Wextra -Wno-long-long -Wno-variadic-macros -Wunused-function -pedantic -DBOOST_ALL_NO_LIB=1 -DBOOST_SYSTEM_DYN_LINK=1 -DBOOST_THREAD_BUILD_DLL=1 -DBOOST_THREAD_DONT_USE_CHRONO -DBOOST_THREAD_POSIX -I".." -o "/home/tomkent/teeks99-04/b/results/boost/bin.v2/libs/thread/build/clang-li nux-3.4/debug/threading-multi/future.o" "../libs/thread/src/future.cpp"
In my local run I got the following error on the latest develop: ./boost/thread/pthread/mutex.hpp:108:21: warning: unused variable 'res' [- Wunused-variable] int const res = posix::pthread_mutex_destroy(&m); ^ In file included from libs/thread/src/pthread/thread.cpp:19: ./boost/thread/future.hpp:3561:9: error: cannot convert 'boost::launch' to 'int' without a conversion operator if (int(policy) & int(launch::async)) { ^~~~~~~~~~ ./boost/thread/future.hpp:3567:16: error: cannot convert 'boost::launch' to 'int' without a conversion operator } else if (int(policy) & int(launch::deferred)) { ^~~~~~~~~~ ./boost/thread/future.hpp:3626:9: error: cannot convert 'boost::launch' to 'int' without a conversion operator if (int(policy) & int(launch::async)) { ^~~~~~~~~~ ./boost/thread/future.hpp:3632:16: error: cannot convert 'boost::launch' to 'int' without a conversion operator } else if (int(policy) & int(launch::deferred)) { ^~~~~~~~~~ 1 warning and 4 errors generated. "clang++" -c -x c++ -Wextra -Wno-long-long -Wno-pedantic -Wno-unused- function -fsanitize=address -Wno-variadic-macros -Wunused-function -pedantic - g -O3 -finline-functions -Wno-inline -Wall -pedantic -g -march=corei7-avx - pthread -fPIC -m64 -Wextra -Wno-long-long -Wno-pedantic -Wno-unused-function - fsanitize=address -Wno-variadic-macros -Wunused-function -pedantic - DBOOST_ALL_NO_LIB=1 -DBOOST_SYSTEM_DYN_LINK=1 -DBOOST_THREAD_BUILD_DLL=1 - DBOOST_THREAD_DONT_USE_CHRONO -DBOOST_THREAD_POSIX -DNDEBUG -I"." -o "bin.v2/libs/thread/build/clang-linux-3.4/release/address-model-64/debug- symbols-on/instruction-set-sandy-bridge/threading-multi/pthread/thread.o" "libs/thread/src/pthread/thread.cpp"
On Monday 09 June 2014 15:00:42 you wrote:
On Monday 09 June 2014 12:49:30 Vicente J. Botet Escriba wrote:
Le 09/06/14 12:25, Andrey Semashev a écrit :
Hi,
I'm seeing mass test failures in Atomic and Log both in develop and master. E.g.:
http://www.boost.org/development/tests/develop/developer/atomic.html http://www.boost.org/development/tests/master/developer/atomic.html
The logs are not descriptive (as usual) but point to Thread compilation:
http://www.boost.org/development/tests/develop/developer/output/teeks99-> > > 04 b-Ubuntu12-04-64-boost-bin-v2-libs-log-test-attr_attribute_set-test-clan g- linux-3-4-debug-threading-multi.html
Could this be resolved? The freeze deadline is nearing, so I'd like to see my test results at least once before it is reached.
I would like to, but with the following log, I'm unable to :(
Vicente
Test output: boost/bin.v2/libs/thread/build/clang-linux-3.4/debug/threading-multi Rev b932921a8ebf5d42337f0b48f46ac77b072f35e7 / Sun, 08 Jun 2014 17:24:48 +0000 Compile [2014-06-08 21:05:30 UTC]: succeed
"clang++-3.4" -c -x c++ -Wextra -Wno-long-long -Wno-variadic-macros
-Wunused-function -pedantic -O0 -g -fno-inline -Wall -pedantic -g -pthread -fPIC -Wextra -Wno-long-long -Wno-variadic-macros -Wunused-function -pedantic -DBOOST_ALL_NO_LIB=1 -DBOOST_SYSTEM_DYN_LINK=1 -DBOOST_THREAD_BUILD_DLL=1 -DBOOST_THREAD_DONT_USE_CHRONO -DBOOST_THREAD_POSIX -I".." -o "/home/tomkent/teeks99-04/b/results/boost/bin.v2/libs/thread/build/clang-l i nux-3.4/debug/threading-multi/future.o" "../libs/thread/src/future.cpp"
In my local run I got the following error on the latest develop:
./boost/thread/pthread/mutex.hpp:108:21: warning: unused variable 'res' [- Wunused-variable] int const res = posix::pthread_mutex_destroy(&m); ^ In file included from libs/thread/src/pthread/thread.cpp:19: ./boost/thread/future.hpp:3561:9: error: cannot convert 'boost::launch' to 'int' without a conversion operator if (int(policy) & int(launch::async)) { ^~~~~~~~~~ ./boost/thread/future.hpp:3567:16: error: cannot convert 'boost::launch' to 'int' without a conversion operator } else if (int(policy) & int(launch::deferred)) { ^~~~~~~~~~ ./boost/thread/future.hpp:3626:9: error: cannot convert 'boost::launch' to 'int' without a conversion operator if (int(policy) & int(launch::async)) { ^~~~~~~~~~ ./boost/thread/future.hpp:3632:16: error: cannot convert 'boost::launch' to 'int' without a conversion operator } else if (int(policy) & int(launch::deferred)) { ^~~~~~~~~~ 1 warning and 4 errors generated.
"clang++" -c -x c++ -Wextra -Wno-long-long -Wno-pedantic -Wno-unused- function -fsanitize=address -Wno-variadic-macros -Wunused-function -pedantic - g -O3 -finline-functions -Wno-inline -Wall -pedantic -g -march=corei7-avx - pthread -fPIC -m64 -Wextra -Wno-long-long -Wno-pedantic -Wno-unused-function - fsanitize=address -Wno-variadic-macros -Wunused-function -pedantic - DBOOST_ALL_NO_LIB=1 -DBOOST_SYSTEM_DYN_LINK=1 -DBOOST_THREAD_BUILD_DLL=1 - DBOOST_THREAD_DONT_USE_CHRONO -DBOOST_THREAD_POSIX -DNDEBUG -I"." -o "bin.v2/libs/thread/build/clang-linux-3.4/release/address-model-64/debug- symbols-on/instruction-set-sandy-bridge/threading-multi/pthread/thread.o" "libs/thread/src/pthread/thread.cpp"
https://github.com/boostorg/thread/pull/11 This fixed the compilation for me.
Vicente J. Botet Escriba wrote:
I would like to, but with the following log, I'm unable to :(
There are some non-empty logs, such as http://www.boost.org/development/tests/develop/developer/output/marshall-mac... but they are cut short because of the ungodly amount of warnings about variadic macros.
On 6/9/2014 7:07 AM, Peter Dimov wrote:
Vicente J. Botet Escriba wrote:
I would like to, but with the following log, I'm unable to :(
There are some non-empty logs, such as
http://www.boost.org/development/tests/develop/developer/output/marshall-mac...
but they are cut short because of the ungodly amount of warnings about variadic macros.
These warnings can be turned off in gcc, and probably by extension in clang, by using the cxx flag '-Wno-variadic-macros'.
Edward Diener wrote:
On 6/9/2014 7:07 AM, Peter Dimov wrote:
There are some non-empty logs, such as
http://www.boost.org/development/tests/develop/developer/output/marshall-mac...
but they are cut short because of the ungodly amount of warnings about variadic macros.
These warnings can be turned off in gcc, and probably by extension in clang, by using the cxx flag '-Wno-variadic-macros'.
Clang does appear to support -Wno-variadic-macros, and some clang testers do have that flag in their invocations. I wonder if this option shouldn't be set by default by the clang toolset though.
Le 09/06/14 18:02, Peter Dimov a écrit :
Edward Diener wrote:
On 6/9/2014 7:07 AM, Peter Dimov wrote:
There are some non-empty logs, such as
http://www.boost.org/development/tests/develop/developer/output/marshall-mac...
but they are cut short because of the ungodly amount of warnings
about > variadic macros.
These warnings can be turned off in gcc, and probably by extension in clang, by using the cxx flag '-Wno-variadic-macros'.
Clang does appear to support -Wno-variadic-macros, and some clang testers do have that flag in their invocations.
I wonder if this option shouldn't be set by default by the clang toolset though.
It seems that in c++98 mode we need -Wno-c99-extensions. Vicente
Le 09/06/14 17:25, Edward Diener a écrit :
On 6/9/2014 7:07 AM, Peter Dimov wrote:
Vicente J. Botet Escriba wrote:
I would like to, but with the following log, I'm unable to :(
There are some non-empty logs, such as
http://www.boost.org/development/tests/develop/developer/output/marshall-mac...
but they are cut short because of the ungodly amount of warnings about variadic macros.
These warnings can be turned off in gcc, and probably by extension in clang, by using the cxx flag '-Wno-variadic-macros'.
Is this flag supported on all gcc/clang versions? Vicente
On Monday 09 June 2014 18:03:51 Vicente J. Botet Escriba wrote:
Le 09/06/14 17:25, Edward Diener a écrit :
On 6/9/2014 7:07 AM, Peter Dimov wrote:
Vicente J. Botet Escriba wrote:
I would like to, but with the following log, I'm unable to :(
There are some non-empty logs, such as
http://www.boost.org/development/tests/develop/developer/output/marshall-> >> mac-boost-bin-v2-libs-thread-test-async__async_p-test-clang-darwin-4-2-1- debug-threading-multi.html
but they are cut short because of the ungodly amount of warnings about variadic macros.
These warnings can be turned off in gcc, and probably by extension in clang, by using the cxx flag '-Wno-variadic-macros'.
Is this flag supported on all gcc/clang versions?
I think these warnings are valid. If the code is intended to be compatible with C++03, variadic macros should not be used. Otherwise the code or test should be disabled.
participants (4)
-
Andrey Semashev -
Edward Diener -
Peter Dimov -
Vicente J. Botet Escriba