[Boost-announce] [Boost] [Review] [Boost.MySQL] - Review Complete

From: Richard Hodges (hodges.r_at_[hidden])
Date: 2022-06-15 18:42:22

Dear All,

The submission of Boost.MySQL has created plenty of "lively debate".

Unsurprisingly, a library which is based on Asio, of which there are few
experts, has given rise to a great deal of questioning around performance,
memory re-use, correct return types and so on.

It has been noted that Reuben, the library's author, has been very
responsive. Both in this mailing list and in terms of raising PRs.

A specific concern was raised about the name of the library, and whether it
infringed any commercial trade marks. Reuben took the trouble to reach out
to Oracle to check. They have responded that there is no infringement and
we may use the name.

In the end though, despite a great deal of words written raising concerns,
ideas and suggestions, we received size reviews, all of which were high
quality.

The results were:
Accept: 3
Conditional Accept: 2
Reject: 1

Having carefully weighed up:
- The stated aims of the library
- The quality of the implementation
- The demonstrated responsiveness of the author
- The value of the library to users of MySQL
- The value of the library as a teaching tool for implementing a complex,
cancellable, asynchronous protocol on ASIO, which correctly adapts to the
use of user-selection completion tokens,

It seems right to ACCEPT this library into Boost.

My congratulations to Reuben.

-- 
Richard Hodges
hodges.r_at_[hidden]
office: [phone]
home: [phone]
mobile: [phone]