Re: [Boost-bugs] [Boost C++ Libraries] #903: inconsistent usage of function pointer typedefs

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #903: inconsistent usage of function pointer typedefs
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2007-07-03 14:58:42

#903: inconsistent usage of function pointer typedefs
--------------------------------------+-------------------------------------
  Reporter:  sebastinas_at_[hidden]  |       Owner:  dave    
      Type:  Patches                  |      Status:  assigned
 Milestone:  Boost 1.35.0             |   Component:  Python  
   Version:  release 1.34.0           |    Severity:  Cosmetic
Resolution:  None                     |    Keywords:          
--------------------------------------+-------------------------------------
Changes (by dave):

  * status:  new => assigned
  * severity:  Showstopper => Cosmetic
  * reporter:  sebastinas => sebastinas_at_[hidden]
  * version:  None => release 1.34.0
  * milestone:  => Boost 1.35.0

Old description:

> {{{
> The us of the function pointer typedef 'convertible_function' is
> inconsistent in boost/python/converter/registry.hpp and
> libs/python/converter/registry.cpp.
>
> In registry.hpp 'insert' is defined as 'void insert(void*
> (*convert)(PyObject*), type_info)' whereas it's 'void
> insert(convertible_function, type_info)' in registry.cpp. The same
> applies to 'void insert(convertible_function, constructor_function,
> type_info)' and 'void push_back(convertible_function,
> constructor_function, type_info)'.
>
> The attached patch replaces the function pointers with the appropriate
> typedefs.
> }}}

New description:

 The us of the function pointer typedef 'convertible_function' is
 inconsistent in boost/python/converter/registry.hpp and
 libs/python/converter/registry.cpp.

 In registry.hpp 'insert' is defined as 'void insert(void*
 (*convert)(PyObject*), type_info)' whereas it's 'void
 insert(convertible_function, type_info)' in registry.cpp. The same applies
 to 'void insert(convertible_function, constructor_function, type_info)'
 and 'void push_back(convertible_function, constructor_function,
 type_info)'.

 The attached patch replaces the function pointers with the appropriate
 typedefs.

-- 
Ticket URL: <http://svn.boost.org/trac/boost/ticket/903#comment:2>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.