Re: [Boost-bugs] [Boost C++ Libraries] #902: patch for Visual Studio 8 + Windows x64 (AMD64)

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #902: patch for Visual Studio 8 + Windows x64 (AMD64)
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2007-07-09 14:00:06

#902: patch for Visual Studio 8 + Windows x64 (AMD64)
----------------------+-----------------------------------------------------
  Reporter:  lsh123   |       Owner:  nobody     
      Type:  Patches  |      Status:  closed     
 Milestone:           |   Component:  None       
   Version:  None     |    Severity:  Showstopper
Resolution:  fixed    |    Keywords:             
----------------------+-----------------------------------------------------
Changes (by grafik):

  * status:  assigned => closed
  * resolution:  None => fixed
  * severity:  => Showstopper

Old description:

> {{{
> This patch adds "vc8" build tool to jam and fixes several issues with
> building boost in Visual Studio 8 on AMD64 platform:
>
> * tools/build/jam_src/build.bat
>
> On Windows 64 the default location for Visual Studio is "C:\Program Files
> (x86)\...". The ( ) confuses the bat file big time and I had to
> workaround it by using quotes and DeQuote function.
>
> * tools/build/jam_src/build.jam and tools/build/jam_src/jambase.c
>
> Simply new "vc8" tool
>
> * tools/build/jam_src/pathunix.c
>
> Changed DWORD -> int because on VC8 DWORD is unsigned which causes
> problem when we have pos=0 (then prev_pos is a huge number and everything
> is screwed).
>
> * boost/config/abi/msvc_prefix.hpp
>
> Make alignment consistent with STLPort.
>
> * boost/config/abi/msvc_prefix.hpp
>
> It seems that this workaround is not needed in the final version of VC 8
>
> * libs/thread/src/once.cpp
>
> This is a known issue (http://lists.boost.org/boost-

> users/2005/09/13765.php). Unfortunately, I can't figure out a better way
> to fix this.
>

> }}}

New description:

 {{{
 This patch adds "vc8" build tool to jam and fixes several issues with
 building boost in Visual Studio 8 on AMD64 platform:

 * tools/build/jam_src/build.bat

 On Windows 64 the default location for Visual Studio is "C:\Program Files
 (x86)\...". The ( ) confuses the bat file big time and I had to workaround
 it by using quotes and DeQuote function.

 * tools/build/jam_src/build.jam and tools/build/jam_src/jambase.c

 Simply new "vc8" tool

 * tools/build/jam_src/pathunix.c

 Changed DWORD -> int because on VC8 DWORD is unsigned which causes problem
 when we have pos=0 (then prev_pos is a huge number and everything is
 screwed).

 * boost/config/abi/msvc_prefix.hpp

 Make alignment consistent with STLPort.

 * boost/config/abi/msvc_prefix.hpp

 It seems that this workaround is not needed in the final version of VC 8

 * libs/thread/src/once.cpp

 This is a known issue (http://lists.boost.org/boost-

 users/2005/09/13765.php). Unfortunately, I can't figure out a better way
 to fix this.


 }}}

Comment:

 AFAICT all the changes are either already done by now, or the code in
 question has been rewritten.

-- 
Ticket URL: <http://svn.boost.org/trac/boost/ticket/902#comment:3>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.