Re: [Boost-bugs] [Boost C++ Libraries] #1432: Missing includes and same compiler warnings

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #1432: Missing includes and same compiler warnings
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2007-12-02 16:05:37

#1432: Missing includes and same compiler warnings
--------------------------------------+-------------------------------------
  Reporter:  jensseidel_at_[hidden]  |       Owner:  rogeeff
      Type:  Patches                  |      Status:  new    
 Milestone:  Boost 1.35.0             |   Component:  test   
   Version:  Boost Development Trunk  |    Severity:  Problem
Resolution:                           |    Keywords:         
--------------------------------------+-------------------------------------
Comment (by Jens Seidel <jensseidel_at_[hidden]>):

 As you probably noticed some minor parts of the patch are wrong (I removed
 e.g
 namespace { check_is_close_t check_is_close; }
 as this isn't used in the header and I misinterpreted the unnamed
 namespace). Please note that I think I read that using variable
 definitions in unnamed namespaces is discouraged and the Boost specific
 vera test published some time ago on the boost
 list complained about this too.

 Nevertheless every other part of the patch should be OK to commit, right?

-- 
Ticket URL: <http://svn.boost.org/trac/boost/ticket/1432#comment:2>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.