[Boost-bugs] [Boost C++ Libraries] #1595: [spirit] missing #includes

Subject: [Boost-bugs] [Boost C++ Libraries] #1595: [spirit] missing #includes
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2008-01-23 10:16:14

#1595: [spirit] missing #includes
-------------------------------------+--------------------------------------
 Reporter:  faridz_at_[hidden]        |       Owner:  djowel     
     Type:  Bugs                     |      Status:  new        
Milestone:  Boost 1.35.0             |   Component:  spirit     
  Version:  Boost Development Trunk  |    Severity:  Showstopper
 Keywords:                           |  
-------------------------------------+--------------------------------------
 The [http://stdcxx.apache.org/ stdcxx] is the another implementation of
 the STL (initially based on RogueWave STL).

     The following errors are encountered when running boost regression
 tests on msvc with stdcxx-4.2.0.

 {{{
 ast_calc_tests.cpp
 ..\boost/spirit/tree/impl/tree_to_xml.ipp(67) : error C3861: 'strlen':
 identifier not found
 ..\libs\spirit\test\ast_calc_tests.cpp(158) : error C3861: 'strtol':
 identifier not found
 }}}

   The proposed patch:

 {{{
 Index: boost/spirit/tree/impl/tree_to_xml.ipp
 ===================================================================
 --- boost/spirit/tree/impl/tree_to_xml.ipp      (revision 42908)
 +++ boost/spirit/tree/impl/tree_to_xml.ipp      (working copy)
 @@ -13,6 +13,7 @@

  #include <cstdio>
  #include <cstdarg>
 +#include <string.h>    // for strlen()
  #include <locale>
  #include <string>

 Index: libs/spirit/test/ast_calc_tests.cpp
 ===================================================================
 --- libs/spirit/test/ast_calc_tests.cpp (revision 42908)
 +++ libs/spirit/test/ast_calc_tests.cpp (working copy)
 @@ -13,6 +13,7 @@
  #include <boost/spirit/tree/tree_to_xml.hpp>
  #include <boost/detail/workaround.hpp>

 +#include <stdlib.h>    // for strtol()
  #include <iostream>
  #include <stack>
  #include <functional>
 }}}

-- 
Ticket URL: <http://svn.boost.org/trac/boost/ticket/1595>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.