Re: [Boost-bugs] [Boost C++ Libraries] #1669: Add more unit tests

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #1669: Add more unit tests
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2008-03-07 23:07:57

#1669: Add more unit tests
--------------------------------------+-------------------------------------
  Reporter:  stefan                   |       Owner:  hkaiser
      Type:  Feature Requests         |      Status:  closed 
 Milestone:  Boost 1.36.0             |   Component:  wave   
   Version:  Boost Development Trunk  |    Severity:  Problem
Resolution:  fixed                    |    Keywords:         
--------------------------------------+-------------------------------------
Changes (by hkaiser):

  * status:  new => closed
  * resolution:  => fixed

Comment:

 Replying to [ticket:1669 stefan]:
 > The wave test suite is right now somewhat incomplete. There are no tests
 checking that the generated output stream is valid. Also, no tests exist
 to make sure the various callbacks (e.g. trace policy) receive correct
 arguments.

 This has been added to the test suite (actually there already have been
 some tests of this, but there are a couple more now).

 > For the first (conforming output) I'd suggest to simple provide input
 that doesn't require any preprocessing, and making sure the generated
 output is identical to that. (This helps detect and eliminate any wrong
 whitespace insertion.)
 > Obviously it's also important to make sure output generation *with*
 macro expansion (etc.) is conform, i.e. the right #line markers are
 generated and so forth.

 This is tested all over the place already. The failing case you provided
 has been added as a test case.

 > For the second set of tests I'd suggest to write a trace policy that
 logs to some stream, and then let the test make sure that log corresponds
 to expected values. (This requires that for each new test a developer
 manually generates (and validates) a reference log, per input file.

 This has been added to the test suite as well, which now verifies the
 generated calls to the preprocessor hooks for about half of the test cases
 (where it made sense to add hook verification). I'll keep adding tests in
 the future, though.

 For now, the code is merged into the trunk only.

-- 
Ticket URL: <http://svn.boost.org/trac/boost/ticket/1669#comment:1>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.