[Boost-bugs] [Boost C++ Libraries] #1820: win_iocp_socket_service::accept() doesn't update error_code

Subject: [Boost-bugs] [Boost C++ Libraries] #1820: win_iocp_socket_service::accept() doesn't update error_code
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2008-04-12 13:28:46

#1820: win_iocp_socket_service::accept() doesn't update error_code
---------------------------------------------------------------+------------
 Reporter:  Takeshi Mouri <takeshi.mouri.net_at_[hidden]>  |       Owner:  chris_kohlhoff
     Type:  Bugs                                               |      Status:  new           
Milestone:  Boost 1.36.0                                       |   Component:  asio          
  Version:  Boost 1.35.0                                       |    Severity:  Problem       
 Keywords:                                                     |  
---------------------------------------------------------------+------------
 In boost/asio/detail/win_iocp_socket_service.cpp,
 {{{
   template <typename Socket>
   boost::system::error_code accept(implementation_type& impl, Socket&
 peer,
       endpoint_type* peer_endpoint, boost::system::error_code& ec)
   {
     // ...

     for (;;)
     {
       boost::system::error_code ec;

       // ...

       return ec;
     }
   }
 }}}
 The inner "ec" hides the function parameter "ec".
 So, this function doesn't set an error code to outer "ec".

 Please remove the inner "ec".

-- 
Ticket URL: <http://svn.boost.org/trac/boost/ticket/1820>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.