Subject: Re: [Boost-bugs] [Boost C++ Libraries] #1462: Missing/wrong includes
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2008-07-12 00:20:23
#1462: Missing/wrong includes
----------------------------------------------------+-----------------------
Reporter: Jens Seidel <jensseidel_at_[hidden]> | Owner: dgregor
Type: Patches | Status: reopened
Milestone: Boost 1.36.0 | Component: Building Boost
Version: Boost Development Trunk | Severity: Problem
Resolution: | Keywords:
----------------------------------------------------+-----------------------
Comment(by rwgk):
Replying to [comment:5 jhunold]:
> This does not work for all gcc-versions:
Yes, it also breaks
g++ (GCC) 3.2 20020903 (Red Hat Linux 8.0 3.2-7)
Red Hat Linux release 8.0 (Psyche)
g++ (GCC) 3.2.3 20030502 (Red Hat Linux 3.2.3-34)
Red Hat Enterprise Linux WS release 3 (Taroon Update 2)
Some history:
- I came up with the patch while testing gcc 4.3 pre-releases.
- After I originally posted the patch above it turned out to need more
if's.
I maintained the changes locally during the 4.3 pre-release period
(I was testing about once a week).
- After gcc 4.3 was released I found out (to my surprise) it is
not required anymore, so I simply removed it from my boost
working copy.
Sorry I didn't communicate this.
The last version of my local patch, before I removed it, was (diff to
current
boost svn):
Index: libstdcpp3.hpp
===================================================================
--- libstdcpp3.hpp (revision 47331)
+++ libstdcpp3.hpp (working copy)
@@ -68,7 +68,10 @@
# define BOOST_HAS_SLIST
# define BOOST_HAS_HASH
# define BOOST_SLIST_HEADER <ext/slist>
-# if defined(__GLIBCXX__) && __GLIBCXX__ < 20071018 // GCC <= 4.3.0
+# if !defined(__GLIBCXX__) \
+ || __GLIBCXX__ < 20071018 \
+ || __GNUC__ < 4 \
+ || (__GNUC__ == 4 && __GNUC_MINOR__ < 3)
# define BOOST_HASH_SET_HEADER <ext/hash_set>
# define BOOST_HASH_MAP_HEADER <ext/hash_map>
# else
I'm not sure the is the final/best set of ifdefs, but at least it restores
the gcc 3.2 builds.
Let me know if I can be of help resolving this issue (e.g. testing
alternative
patches or simply checking this one in).
-- Ticket URL: <http://svn.boost.org/trac/boost/ticket/1462#comment:6> Boost C++ Libraries <http://www.boost.org/> Boost provides free peer-reviewed portable C++ source libraries.
This archive was generated by hypermail 2.1.7 : 2017-02-16 18:49:58 UTC