Re: [Boost-bugs] [Boost C++ Libraries] #2069: #elif behaviour in gcc 4.4

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #2069: #elif behaviour in gcc 4.4
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2008-09-15 20:05:03

#2069: #elif behaviour in gcc 4.4
---------------------------------------------+------------------------------
  Reporter:  tim blechmann <tim_at_[hidden]>  |       Owner:  danieljames 
      Type:  Bugs                            |      Status:  assigned    
 Milestone:  Boost 1.37.0                    |   Component:  preprocessor
   Version:  Boost 1.35.0                    |    Severity:  Problem     
Resolution:                                  |    Keywords:              
---------------------------------------------+------------------------------

Comment(by danieljames):

 Oh very clever. I wish I'd seen that you'd done that before doing some of
 them manually. I'm feeling stupid now.

 Your patch looks good. To be picky, the comments are a bit mismatched -
 you've put 'gcc 4.4 compatability' on the `#else` from the outer if
 statement and the `#endif` from the inner statement. That could be
 confusing and it should be easy to fix. I'd suggest something like:

 {{{
 // For gcc 4.4 compatability, we must include the
 // BOOST_PP_ITERATION_DEPTH test inside an #else clause.
 #else // BOOST_PP_IS_ITERATING
 #if BOOST_PP_ITERATION_DEPTH() == 1
 }}}

 and at the end:

 {{{
 #endif // BOOST_PP_ITERATION_DEPTH()
 }}}

 But feel free to do it however you want.

 I'm not set up for testing Boost.Python, but I can test the other
 libraries - so it's very convenient can you can test it. Can you create a
 ticket for just the python changes (include a link to this ticket, ie.
 #2069), and I'll deal with the other libraries. function_types is a bit of
 a problem as I'm getting failures on gcc 4.3 and the code to be changed
 looks a little odd already.

 Thanks for your help.

-- 
Ticket URL: <http://svn.boost.org/trac/boost/ticket/2069#comment:7>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.