Re: [Boost-bugs] [Boost C++ Libraries] #2345: [mpl] Patch to improve support for CodeGear C++Builder 2009

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #2345: [mpl] Patch to improve support for CodeGear C++Builder 2009
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2008-10-08 02:50:25

#2345: [mpl] Patch to improve support for CodeGear C++Builder 2009
--------------------------------------+-------------------------------------
  Reporter:  nmusatti                 |       Owner:  agurtovoy
      Type:  Patches                  |      Status:  assigned 
 Milestone:  To Be Determined         |   Component:  mpl      
   Version:  Boost Development Trunk  |    Severity:  Problem  
Resolution:                           |    Keywords:           
--------------------------------------+-------------------------------------

Comment(by agurtovoy):

 Overall, it looks good. A couple of questions:

 1. In "assert.hpp", why

 {{{
 -#if BOOST_WORKAROUND(__BORLANDC__, >= 0x560) &&
 BOOST_WORKAROUND(__BORLANDC__, < 0x600) \
 +#if BOOST_WORKAROUND(__BORLANDC__, BOOST_TESTED_AT(0x610)) \
 }}}

 vs.

 {{{
 -#if BOOST_WORKAROUND(__BORLANDC__, >= 0x560) &&
 BOOST_WORKAROUND(__BORLANDC__, < 0x600) \
 +#if BOOST_WORKAROUND(__BORLANDC__, >= 0x560) &&
 BOOST_WORKAROUND(__BORLANDC__, BOOST_TESTED_AT(0x610)) \
 }}}
 ?

 2. In "quote.hpp", why

 {{{
 -#if defined(BOOST_MPL_CFG_NO_TEMPLATE_TEMPLATE_PARAMETERS)
 +#if defined(BOOST_MPL_CFG_NO_TEMPLATE_TEMPLATE_PARAMETERS) &&
 !BOOST_WORKAROUND( __BORLANDC__, >=0x590 )
  #   define BOOST_MPL_CFG_NO_QUOTE_TEMPLATE
  #endif
 }}}

 vs. modifying BOOST_MPL_CFG_NO_TEMPLATE_TEMPLATE_PARAMETERS condition in
 "aux_/config/ttp.hpp"?

 3. Changes to "apply_wrap.hpp" and "quote.hpp" won't have any effect until
 we regenerate preprocessed headers. Were you testing the whole thing with
 BOOST_MPL_CFG_NO_PREPROCESSED_HEADERS defined?

-- 
Ticket URL: <http://svn.boost.org/trac/boost/ticket/2345#comment:3>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.