Re: [Boost-bugs] [Boost C++ Libraries] #2563: [boost][serialization] void_upcast is very slow

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #2563: [boost][serialization] void_upcast is very slow
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2008-12-11 16:28:02

#2563: [boost][serialization] void_upcast is very slow
----------------------------------+-----------------------------------------
  Reporter:  jacobholm_at_[hidden]  |       Owner:  ramey        
      Type:  Feature Requests     |      Status:  closed       
 Milestone:  Boost 1.38.0         |   Component:  serialization
   Version:  Boost 1.37.0         |    Severity:  Optimization 
Resolution:  invalid              |    Keywords:               
----------------------------------+-----------------------------------------
Changes (by ramey):

  * status:  assigned => closed
  * resolution:  => invalid

Comment:

 I've looked at the code and your test.  I've concluded the following:

 a) I won't dispute that void_upcast is slower than a static cast.  It may
 be possible to make it faster.
 b) I double checked the serialization code to verify that void_upcast was
 only being invoked when it was absolutely necessary.  I'm satisfied that
 it is.
 c) So I've concluded that your proposed change will cause the
 serialization library to fail except in some cases.
 d) I took a look at your test.  It's not obvious to me what it is actually
 meant to show and how it would relate to the replacement of void_upcast
 with a static cast.

 Robert Ramey

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/2563#comment:3>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.