[Boost-bugs] [Boost C++ Libraries] #2909: Wrong type signatures?

Subject: [Boost-bugs] [Boost C++ Libraries] #2909: Wrong type signatures?
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2009-04-03 13:11:48

#2909: Wrong type signatures?
--------------------------+-------------------------------------------------
 Reporter:  bhy           |       Owner:  dave   
     Type:  Bugs          |      Status:  new    
Milestone:  Boost 1.39.0  |   Component:  Python 
  Version:  Boost 1.38.0  |    Severity:  Problem
 Keywords:                |  
--------------------------+-------------------------------------------------
 In python/converter/builtin_converters.hpp, I found these lines:

 BOOST_PYTHON_TO_PYTHON_BY_VALUE(signed BOOST_PYTHON_LONG_LONG,
 ::PyLong_FromLongLong(x), &PyInt_Type)
 BOOST_PYTHON_TO_PYTHON_BY_VALUE(unsigned BOOST_PYTHON_LONG_LONG,
 ::PyLong_FromUnsignedLongLong(x), &PyInt_Type)

 and,

 BOOST_PYTHON_TO_PYTHON_BY_VALUE(std::wstring,
 ::PyUnicode_FromWideChar(x.data(),implicit_cast<ssize_t>(x.size())),
 &PyString_Type)

 Seems it is a typo. Should the PyInt_Type be PyLong_Type, and the
 PyString_Type be PyUnicode_Type?

 These macro argument is used for generate the return value of
 get_pytype(). And seems get_pytype() is only used to generate docstring.
 So there's accutally no problem caused by these.

 But, should these be typo? If so, we'd better fix it.

 Thanks!

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/2909>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.