[Boost-bugs] [Boost C++ Libraries] #3047: Potential redifinitions in visualc of BOOST_DISABLE_WIN32 and BOOST_NO_RTTI

Subject: [Boost-bugs] [Boost C++ Libraries] #3047: Potential redifinitions in visualc of BOOST_DISABLE_WIN32 and BOOST_NO_RTTI
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2009-05-19 05:01:11


#3047: Potential redifinitions in visualc of BOOST_DISABLE_WIN32 and BOOST_NO_RTTI
-----------------------------------------------------------------------+----
 Reporter: nstewart_at_[hidden] | Owner: johnmaddock
     Type: Patches | Status: new
Milestone: Boost 1.40.0 | Component: config
  Version: Boost 1.38.0 | Severity: Cosmetic
 Keywords: define, redefinition, BOOST_DISABLE_WIN32, BOOST_NO_RTTI |
-----------------------------------------------------------------------+----
 There is some auto-detection logic in
 boost-1.38.0/boost/config/compiler/visualc.hpp to define
 BOOST_DISABLE_WIN32 and BOOST_NO_RTTI, depending on the environment.

 In our setup BOOST_NO_RTTI is already defined across all platform
 toolchains, and the logic results in a warning:

 .../boost-1.38.0\boost/config/compiler/visualc.hpp(136) : warning C4005:
 'BOOST_NO_RTTI' : macro redefinition
         304 command-line arguments : see previous
 definition of 'BOOST_NO_RTTI'

 This proposes patch will prevent the redefinition of these defines, if
 they are already defined.

 The issue appears to be unresolved in 1.39.0

 The suggested patch w.r.t. 1.38.0:

 132c132
 < #ifndef _MSC_EXTENSIONS
 ---
> #if !defined(_MSC_EXTENSIONS) && !defined(BOOST_DISABLE_WIN32)
 135c135
 < #ifndef _CPPRTTI
 ---
> #if !defined(_CPPRTTI) && !defined(BOOST_NO_RTTI)

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/3047>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.

This archive was generated by hypermail 2.1.7 : 2017-02-16 18:50:00 UTC