[Boost-bugs] [Boost C++ Libraries] #3422: Bad workaround for BOOST_NO_STDC_NAMESPACE in codecvt_null.hpp

Subject: [Boost-bugs] [Boost C++ Libraries] #3422: Bad workaround for BOOST_NO_STDC_NAMESPACE in codecvt_null.hpp
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2009-09-08 10:47:06

#3422: Bad workaround for BOOST_NO_STDC_NAMESPACE in codecvt_null.hpp
---------------------------------------+------------------------------------
 Reporter:  andysem                    |       Owner:  ramey        
     Type:  Bugs                       |      Status:  new          
Milestone:  Boost 1.41.0               |   Component:  serialization
  Version:  Boost 1.40.0               |    Severity:  Problem      
 Keywords:  codecvt_null msvc stlport  |  
---------------------------------------+------------------------------------
 I'm trying to compile the 1.40 version of the library with MSVC 7.1 &
 STLPort 5.1.4 and having these errors:

 {{{
 boost\archive\codecvt_null.hpp(30) : error C2039: 'codecvt' : is not a
 member of 'operator``global namespace'''
 boost\archive\codecvt_null.hpp(30) : error C2873: 'codecvt' : symbol
 cannot be used in a using-declaration
 }}}

 The problem is twofold.
 1. There is namespace std opening missing after the #if
 defined(BOOST_NO_STDC_NAMESPACE) condition. Likewise, the closing brace
 should be before the matching #endif.
 2. Since STLPort does import codecvt into its namespace (which aliases
 std), the !defined(UNDER_CE) condition is needless and causes my problems.
 I don't know if there are any platforms with codecvt in the global
 namespace, but MSVC 7.1 with STLPort is not one of them.

 I attached the patch with the both fixes.

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/3422>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.