Re: [Boost-bugs] [Boost C++ Libraries] #1860: zip_iterator::value_type should not be reference

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #1860: zip_iterator::value_type should not be reference
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2009-11-28 18:23:47

#1860: zip_iterator::value_type should not be reference
--------------------------+-------------------------------------------------
 Reporter:  anonymous     |       Owner:  mgaunard
     Type:  Bugs          |      Status:  new     
Milestone:  Boost 1.36.0  |   Component:  iterator
  Version:  Boost 1.35.0  |    Severity:  Problem 
 Keywords:                |  
--------------------------+-------------------------------------------------
Changes (by dave):

  * owner:  dave => mgaunard

Comment:

 One reason is that I don't have a testcase that is actually reliable.  You
 see, {{{zip_iterator}}} ''can't'' be a legit C++03 Forward Iterator, since
 its {{{reference}}} type is not a real reference.  Therefore, the standard
 library has a right to refuse to compile the example you gave even without
 the patch.  It may work on your installation and legitimately break
 somewhere else.

 So, if you could build a testcase that doesn't rely on strict {{{Forward
 Iterator}}} conformance, but instead captures the assumptions that your
 {{{std::sort}}} implementation is making, that make this work, I'd be more
 than happy to accept the patch as a QOI improvement.

 A smaller issue is the definition of {{{iterator_value_type}}} is
 redundant with {{{iterator_value}}} in
 {{{<boost/iterator/iterator_traits.hpp>}}}

 Thanks for your efforts and patience on this one.

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/1860#comment:3>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.