Re: [Boost-bugs] [Boost C++ Libraries] #3901: ASIO and macro min and max on Windows

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #3901: ASIO and macro min and max on Windows
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2010-02-15 12:47:17

#3901: ASIO and macro min and max on Windows
-------------------------------+--------------------------------------------
 Reporter:  habdank@…          |       Owner:  chris_kohlhoff
     Type:  Bugs               |      Status:  new           
Milestone:  Boost 1.43.0       |   Component:  asio          
  Version:  Boost 1.40.0       |    Severity:  Problem       
 Keywords:                     |  
-------------------------------+--------------------------------------------

Comment(by habdank@…):

 Hi,

 To be honest I disagree that it is not a matter of ASIO.

 This is a matter of good encapsulation. Inclusion of the windows.h
 is a private matter of ASIO. Even more if ASIO would use PIMPL
 idiom maybe no one would be affected by that macros.

 Also consider that if ASIO will stop using windows.h for some reasons,
 any code will be still affected - then by having useless undefs or
 NOMINMAX build flag.

 As I told that macros are conflicting with standard C++.

 Off course I could build my software with NOMINMAX flag or do
 the #undef on my own :-).

 Best regards,
 Seweryn Habdank-Wojewodzki.

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/3901#comment:2>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.