Re: [Boost-bugs] [Boost C++ Libraries] #3723: gzip_docompressor error - basic_array_source no putback member

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #3723: gzip_docompressor error - basic_array_source no putback member
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2010-03-06 14:15:49

#3723: gzip_docompressor error - basic_array_source no putback member
--------------------------+-------------------------------------------------
 Reporter:  jose          |       Owner:  turkanis   
     Type:  Bugs          |      Status:  new        
Milestone:  Boost 1.42.0  |   Component:  iostreams  
  Version:  Boost 1.41.0  |    Severity:  Showstopper
 Keywords:                |  
--------------------------+-------------------------------------------------

Comment(by danieljames):

 This looks wrong to me, I don't think you should be modifying the source
 array. IMO the correct solution is to remove the call to putback in
 `basic_gzip_decompressor::peekable_source::putback` and change it so that
 it either throws an error or puts the character at the start of the
 buffer. The attached patch does the former, looking at the gzip
 implementation it only ever calls putback with a string or immediately
 after reading a character so it should never throw. Does it look okay to
 you?

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/3723#comment:3>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.