Re: [Boost-bugs] [Boost C++ Libraries] #4214: Use collection_size_type/version_type consistently (fixes Boost.MPI)

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #4214: Use collection_size_type/version_type consistently (fixes Boost.MPI)
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2010-05-16 02:57:57


#4214: Use collection_size_type/version_type consistently (fixes Boost.MPI)
--------------------------------------+-------------------------------------
  Reporter: dgregor | Owner: ramey
      Type: Patches | Status: reopened
 Milestone: Boost 1.44.0 | Component: serialization
   Version: Boost Development Trunk | Severity: Problem
Resolution: | Keywords:
--------------------------------------+-------------------------------------
Changes (by ramey):

  * status: closed => reopened
  * resolution: fixed =>

Comment:

 I'm a little concerned that this might break the ability to read older
 archives. Did you consider this?

 I think what may have happened is:

 a) I changed version_type unsigned char
 b) so an archive is created with a different type than before.
 c) then when things are read in - we read 16 bit int - error.
 d) so you've fixed it so that now it reads an 8 bit type. - no error on
 test.
 e) BUT - now any attempt to read an archive created in a previous system
 won't work - IT will have an error when it is trying to load.

 In short, I think I introduced a bug in 1.43 (or ? 1.42). and that now
 we've fixed it in the wrong place. The best fix is likely:

 a) increment the value returned by get_libray_version()
 b) include conditional code around your fix.

 Does this make sense to you?

 Robert Ramey

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/4214#comment:3>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.

This archive was generated by hypermail 2.1.7 : 2017-02-16 18:50:03 UTC