Re: [Boost-bugs] [Boost C++ Libraries] #4704: Support for multicapture and balancing groups

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #4704: Support for multicapture and balancing groups
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2010-10-07 00:37:46

#4704: Support for multicapture and balancing groups
  Reporter: erik@… | Owner: eric_niebler
      Type: Feature Requests | Status: assigned
 Milestone: To Be Determined | Component: xpressive
   Version: Boost 1.44.0 | Severity: Not Applicable
Resolution: | Keywords: xpressive

Comment (by eric_niebler):

 The capture conditional:

> dynamic: (?P(name)stuff)

 Looking at the implementation of this in parse_group, "stuff" is parsed by
 calling parse_sequence. Is it really the case that stuff can not have
 alternates? Can I not say "(?P(name)this|that)"? If so, this would be the
 only grouping construct that does not permit alternates. I have a bad
 feeling about that. Note that your implementation of that feature ends up
 returning early---the only one to do so---and doesn't reset the traits
 flags. In short, this feels like a great big ugly hack to me. Can you
 clean this up?

 Also, would be very nice if you followed my coding convention. Eg:

        // 4 space indent

 not this:

    if (this) {
      // 2 space indent

 Finally, all these new features need documentation.

 Still reviewing your code, more comments to come I'm sure. Don't be
 discouraged, I still am very happy to have your contribution and have
 every intention of accepting it, once the kinks are worked out.

Ticket URL: <>
Boost C++ Libraries <>
Boost provides free peer-reviewed portable C++ source libraries.

This archive was generated by hypermail 2.1.7 : 2017-02-16 18:50:04 UTC