Re: [Boost-bugs] [Boost C++ Libraries] #4704: Support for multicapture and balancing groups

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #4704: Support for multicapture and balancing groups
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2010-10-07 01:16:14

#4704: Support for multicapture and balancing groups
--------------------------------+-------------------------------------------
  Reporter:  erik@…             |       Owner:  eric_niebler  
      Type:  Feature Requests   |      Status:  assigned      
 Milestone:  To Be Determined   |   Component:  xpressive     
   Version:  Boost 1.44.0       |    Severity:  Not Applicable
Resolution:                     |    Keywords:  xpressive     
--------------------------------+-------------------------------------------

Comment (by eric_niebler):

 Oh wait! I just realized from looking at your change to
 {{{mark_end_matcher}}} that you are //always// populating the
 {{{captures}}} member of the {{{sub_match}}} struct (for non-hidden
 captures). This will have disastrous performance implications. There
 cannot potentially be an allocation every time you match a marked sub-
 expression. I can't accept this change.

 I suggest you find a way to make this behavior opt-in.

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/4704#comment:5>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.