[Boost-bugs] [Boost C++ Libraries] #4779: real test expected failure should be marked as such

Subject: [Boost-bugs] [Boost C++ Libraries] #4779: real test expected failure should be marked as such
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2010-10-23 21:35:33

#4779: real test expected failure should be marked as such
----------------------------------------+-----------------------------------
 Reporter:  Jim Bell <jim@…>            |       Owner:  djowel     
     Type:  Tasks                       |      Status:  new        
Milestone:  Boost-1.45.0                |   Component:  spirit     
  Version:  Boost Development Trunk     |    Severity:  Showstopper
 Keywords:                              |  
----------------------------------------+-----------------------------------
 The qi/real.cpp test failure is described as expected in source-code
 comments, and indeed fails on every platform.
 {{{
 ..\libs\spirit\test\qi\real.cpp(421): test 'test_attr("123233.4124",
 float_, f) && f == 123233.4140625f' failed in function 'int main()'
 1 error detected.
 }}}

 This failure reduces the value of the other tests in qi/real that do pass,
 as the whole test is marked failed.

 Further, this failure causes the entire spirit library to be marked as
 fail/yellow across every platform.

 I suggest splitting the expected failure into a separate test and marking
 it as an expected failure (see the regression test legend at the bottom of
 the page). This would better reflect the state of both qi/real and the
 entire spirit library.

 Also, shouldn't the local compare() function be used here instead of
 operator==()?

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/4779>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.