[Boost-bugs] [Boost C++ Libraries] #4791: boost/token_functions.hpp: warning isspace/ispunct called with wrong character type

Subject: [Boost-bugs] [Boost C++ Libraries] #4791: boost/token_functions.hpp: warning isspace/ispunct called with wrong character type
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2010-10-26 07:14:07


#4791: boost/token_functions.hpp: warning isspace/ispunct called with wrong
character type
-----------------------------------+----------------------------------------
 Reporter: arnetheduck@… | Owner: jsiek
     Type: Patches | Status: new
Milestone: To Be Determined | Component: tokenizer
  Version: Boost 1.44.0 | Severity: Problem
 Keywords: |
-----------------------------------+----------------------------------------
 When using a date_time parser, MSVC reports warning C6328 because ispunct
 / iswpunct and isspace/iswspace are called with the wrong type.

 The char_type should be extended to int / wint_t to accomodate all valid
 values and EOF/WEOF.

 The following patch (against 1.44.0) solves the issue.

 {{{
 === modified file boost/token_functions.hpp
 --- boost/token_functions.hpp 2010-10-07 09:40:43 +0000
 +++ boost/token_functions.hpp 2010-10-25 11:25:48 +0000
 @@ -218,9 +218,9 @@
      {
  #if !defined(BOOST_NO_CWCTYPE)
        if (sizeof(char_type) == 1)
 - return std::isspace(c) != 0;
 + return std::isspace(static_cast<int>(c)) != 0;
        else
 - return std::iswspace(c) != 0;
 + return std::iswspace(static_cast<std::wint_t>(c)) != 0;
  #else
        return static_cast< unsigned >(c) <= 255 && std::isspace(c) != 0;
  #endif
 @@ -230,9 +230,9 @@
      {
  #if !defined(BOOST_NO_CWCTYPE)
        if (sizeof(char_type) == 1)
 - return std::ispunct(c) != 0;
 + return std::ispunct(static_cast<int>(c)) != 0;
        else
 - return std::iswpunct(c) != 0;
 + return std::iswpunct(static_cast<std::wint_t>(c)) != 0;
  #else
        return static_cast< unsigned >(c) <= 255 && std::ispunct(c) != 0;
  #endif

 }}}

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/4791>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.

This archive was generated by hypermail 2.1.7 : 2017-02-16 18:50:04 UTC