[Boost-bugs] [Boost C++ Libraries] #4919: gil_concept.hpp triggers self-assignment warnings

Subject: [Boost-bugs] [Boost C++ Libraries] #4919: gil_concept.hpp triggers self-assignment warnings
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2010-12-01 21:05:58

#4919: gil_concept.hpp triggers self-assignment warnings
-------------------------------+--------------------------------------------
 Reporter:  gromer@…           |       Owner:  hljin  
     Type:  Bugs               |      Status:  new    
Milestone:  To Be Determined   |   Component:  GIL    
  Version:  Boost 1.45.0       |    Severity:  Problem
 Keywords:                     |  
-------------------------------+--------------------------------------------
 boost/gil/gil_concept.hpp contains several instances of assigning a
 variable to itself. In context, this is perfectly safe (since the code
 should never actually be executed), but it nonetheless triggers gcc's
 -Wself-assign, cluttering the build output for those who have that flag
 set, and breaking the build for those who also set -Werror.

 I am unable to suggest a fix for the instance in PointNDConcept, because
 the line in question ("point[0] = point[0];", line 276) appears to be
 checking properties that are not part of the concept as documented; I can
 find no documentation of the fact that models of PointNDConcept are
 expected to have an operator[], much less what the parameter and return
 types of that operator are.

 The attached patch contains trivial fixes for the other instances, which I
 believe have no impact on correctness or performance.

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/4919>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.