Re: [Boost-bugs] [Boost C++ Libraries] #4649: token_functions.hpp (220) : fix for warning C4127 conditional expression is constant

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #4649: token_functions.hpp (220) : fix for warning C4127 conditional expression is constant
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2011-01-20 12:13:28

#4649: token_functions.hpp (220) :  fix for warning C4127 conditional expression
is constant
------------------------------------------------------------+---------------
  Reporter:  Andrew Macgregor <aamacgregor@…>               |       Owner:  jsiek    
      Type:  Bugs                                           |      Status:  new      
 Milestone:  To Be Determined                               |   Component:  tokenizer
   Version:  Boost 1.44.0                                   |    Severity:  Problem  
Resolution:                                                 |    Keywords:  isspace  
------------------------------------------------------------+---------------

Comment (by anonymous):

 Thanks Marshall, sorry for the inconveniences caused by a bad patch.

 I think the adjusted patch is missing something.
 There's a remaining const expression "if (sizeof(char)==1)" in
 traits_extension::ispunct  that should be removed.


 {{{
     static bool ispunct(char_type c)
     {
 #if !defined(BOOST_NO_CWCTYPE)
       return traits_extension_details<traits,
 sizeof(char_type)>::ispunct(c);
 #else
       return static_cast< unsigned >(c) <= 255 && std::ispunct(c) != 0;
 #endif
     }
 }}}

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/4649#comment:4>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.