Re: [Boost-bugs] [Boost C++ Libraries] #3996: Enable use of BOOST_FOREACH over const-ref of noncopyable ptr_containers

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #3996: Enable use of BOOST_FOREACH over const-ref of noncopyable ptr_containers
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2011-04-02 11:06:19

#3996: Enable use of BOOST_FOREACH over const-ref of noncopyable ptr_containers
--------------------------------------------------------+-------------------
  Reporter:  Kazutoshi Satoda <k_satoda@…>              |       Owner:  nesotto                     
      Type:  Patches                                    |      Status:  reopened                    
 Milestone:  To Be Determined                           |   Component:  ptr_container               
   Version:  Boost Development Trunk                    |    Severity:  Problem                     
Resolution:                                             |    Keywords:  BOOST_FOREACH is_noncopyable
--------------------------------------------------------+-------------------
Changes (by Kazutoshi Satoda <k_satoda@…>):

  * status:  closed => reopened
  * version:  Boost 1.42.0 => Boost Development Trunk
  * resolution:  fixed =>
  * milestone:  Boost 1.43.0 => To Be Determined

Comment:

 Replying to [comment:7 nesotto]: I verified that the problem is still
 not fixed at trunk r70851. I assume you missed the problem because you
 tested with a compiler that enables
 BOOST_FOREACH_COMPILE_TIME_CONST_RVALUE_DETECTION.

 Now, I made the 3rd patch. This version contains a test which will can
 show the problem in all compilers, and takes care of ODR violation which
 Eric Niebler pointed out.

 Only one test "const_element_containers" fails on my machine
 (cygwinx86, g++ 4.3.4):
 > const_element_containers.cpp:19: error: expected primary-expression
 before 'template'
 > const_element_containers.cpp:19: error: expected `;' before 'template'
 > ...
 But I'm assuming this is not caused by my change because it is syntax
 errors in the test code.

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/3996#comment:8>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.