[Boost-bugs] [Boost C++ Libraries] #5892: Why using pragma instead of fixing simple warnings?

Subject: [Boost-bugs] [Boost C++ Libraries] #5892: Why using pragma instead of fixing simple warnings?
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2011-09-13 01:02:57

#5892: Why using pragma instead of fixing simple warnings?
-------------------------------------------------+--------------------------
 Reporter:  christophe vial <cvial@…>            |       Owner:  emildotchevski
     Type:  Support Requests                     |      Status:  new           
Milestone:  To Be Determined                     |   Component:  exception     
  Version:  Boost 1.47.0                         |    Severity:  Cosmetic      
 Keywords:                                       |  
-------------------------------------------------+--------------------------
 In boost/exception/detail/error_info_impl.hpp, a gnu pragma was added to
 hide a warning that seems to be simple to fix (changing a member function
 argument name so it does not hide a member with the same name).

 I can understand using pragma for things which are complex and will take
 time and effort to fix, but should we use the pragma for simple cases too?

 I don't think that was the intent of the document:
 https://svn.boost.org/trac/boost/wiki/Guidelines/WarningsGuidelines.


 This may seem cosmetic, but for the long term it could impact the overall
 quality if pragma proliferate and hide real issues.

 Thanks,
 Christophe

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/5892>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.