Re: [Boost-bugs] [Boost C++ Libraries] #5905: Making switch matching on the result type of a transform

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #5905: Making switch matching on the result type of a transform
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2011-09-19 21:43:56

#5905: Making switch matching on the result type of a transform
--------------------------------------------------+-------------------------
  Reporter:  Pierre Esterie <pesterie@…>          |       Owner:  eric_niebler
      Type:  Patches                              |      Status:  new         
 Milestone:  To Be Determined                     |   Component:  proto       
   Version:  Boost 1.47.0                         |    Severity:  Optimization
Resolution:                                       |    Keywords:              
--------------------------------------------------+-------------------------

Comment (by eric_niebler):

 Looks good. Some feedback. The biggest problem is the lack of changes to
 the reference docs for `switch_` (see
 libs/proto/doc/reference/matches.xml), the missing new_switch.cpp test
 file, and the formatting that is inconsistent with the rest of Proto's
 source code. Note: I use 4-spaces for indenting.

 Also, you can remove the specialization of `switch_::impl` in the primary
 `switch_` template. It's still necessary in the specialization of
 `switch_` for the default transform.

 Thanks for your work on this!

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/5905#comment:1>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.