Re: [Boost-bugs] [Boost C++ Libraries] #4297: [PATCH] Fix for warning: enumeral and non-enumeral type in conditional expression

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #4297: [PATCH] Fix for warning: enumeral and non-enumeral type in conditional expression
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2011-10-12 10:05:40

#4297: [PATCH] Fix for warning: enumeral and non-enumeral type in conditional
expression
--------------------------------------------+-------------------------------
  Reporter:  Lénaïc Huard <lhuard@…>        |       Owner:  igaztanaga  
      Type:  Patches                        |      Status:  closed      
 Milestone:  Boost 1.45.0                   |   Component:  interprocess
   Version:  Boost 1.45.0                   |    Severity:  Cosmetic    
Resolution:  fixed                          |    Keywords:  interprocess
--------------------------------------------+-------------------------------

Comment (by Lénaïc Huard <lhuard@…>):

 Indeed, I confirm that the warning is still present with Boost 1.47.

 The clean way to fix it is definitely to replace all the enums in
 metafunctions by the usage of BOOST_STATIC_CONSTANT as recommended in the
 [http://www.boost.org/development/int_const_guidelines.html Coding
 Guidelines for Integral Constant Expressions] page and as I proposed in
 [https://svn.boost.org/trac/boost/attachment/ticket/4297/boost_interprocess_2.patch

 boost_interprocess_2.patch].

 But as far as I can see, my patch has still not been applied in Boost
 1.47.

 Ex:
 [http://svn.boost.org/svn/boost/tags/release/Boost_1_47_0/boost/interprocess/detail/type_traits.hpp

 type_traits.hpp of Boost 1.47]

 There are still enums whereas I replaced them by BOOST_STATIC_CONSTANT in
 [https://svn.boost.org/trac/boost/attachment/ticket/4297/boost_interprocess_2.patch

 boost_interprocess_2.patch].

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/4297#comment:7>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.