[Boost-bugs] [Boost C++ Libraries] #6185: _SCL_SECURE_NO_WARNINGS macro redefinition in Boost.Move

Subject: [Boost-bugs] [Boost C++ Libraries] #6185: _SCL_SECURE_NO_WARNINGS macro redefinition in Boost.Move
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2011-11-30 02:30:56

#6185: _SCL_SECURE_NO_WARNINGS macro redefinition in Boost.Move
-------------------------------------------+--------------------------------
 Reporter:  a.tinsmith@…                   |       Owner:  igaztanaga
     Type:  Bugs                           |      Status:  new       
Milestone:  To Be Determined               |   Component:  move      
  Version:  Boost 1.48.0                   |    Severity:  Problem   
 Keywords:  _SCL_SECURE_NO_WARNINGS C4005  |  
-------------------------------------------+--------------------------------
 In the "boost/move/move.hpp" (line 28) header file _SCL_SECURE_NO_WARNINGS
 macro is defined without checking whether previous definition exists:

 {{{
 #ifdef BOOST_MSVC
    #ifndef _CRT_SECURE_NO_DEPRECATE
    #define  BOOST_INTERPROCESS_CRT_SECURE_NO_DEPRECATE
    #define _CRT_SECURE_NO_DEPRECATE
    #define _SCL_SECURE_NO_WARNINGS
    #endif
    #pragma warning (push)
    #pragma warning(disable:4996)
 #endif
 }}}

 Correct code:

 {{{
 #ifdef BOOST_MSVC
    #ifndef _CRT_SECURE_NO_DEPRECATE
    #define  BOOST_INTERPROCESS_CRT_SECURE_NO_DEPRECATE
    #define _CRT_SECURE_NO_DEPRECATE
    #endif
    #ifndef _SCL_SECURE_NO_WARNINGS
    #define _SCL_SECURE_NO_WARNINGS
    #endif
    #pragma warning (push)
    #pragma warning(disable:4996)
 #endif
 }}}

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/6185>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.