Re: [Boost-bugs] [Boost C++ Libraries] #7111: Switch case's default missing in date_time

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #7111: Switch case's default missing in date_time
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2012-07-10 14:20:48


#7111: Switch case's default missing in date_time
-------------------------------------------------+--------------------------
  Reporter: Gaurav Gupta <g.gupta@…> | Owner: az_sw_dude
      Type: Bugs | Status: new
 Milestone: To Be Determined | Component: date_time
   Version: Boost 1.51.0 | Severity: Problem
Resolution: | Keywords:
-------------------------------------------------+--------------------------

Comment (by marshall):

 I'm sorry, but I don't see the point of this change.

 The code here is checking for all the possible values of the
 month_format_spec enum; there are no other (legal) values.

 Also, your patch does not change the behavior of the code; if an invalid
 value was returned the by `month_format()`, the current code would do
 nothing, and your patch would change it so that it would ... do nothing.

 Please tell me what you are trying to accomplish here.

 P.S. I am completely missing what you mean by:

>''In case of default, code should break from the loop.''

 since I don't see a loop here.

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/7111#comment:1>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.

This archive was generated by hypermail 2.1.7 : 2017-02-16 18:50:10 UTC