Re: [Boost-bugs] [Boost C++ Libraries] #6659: Filesystem compilation broken on Solaris 9 and 10

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #6659: Filesystem compilation broken on Solaris 9 and 10
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2012-07-13 12:54:04

#6659: Filesystem compilation broken on Solaris 9 and 10
----------------------------------------------+-----------------------------
  Reporter:  Vasily Sukhanov <basil@…>        |       Owner:  bemandawes 
      Type:  Bugs                             |      Status:  assigned   
 Milestone:  To Be Determined                 |   Component:  filesystem 
   Version:  Boost 1.49.0                     |    Severity:  Regression 
Resolution:                                   |    Keywords:  compilation
----------------------------------------------+-----------------------------

Comment (by bemandawes):

 Test_fchmodat.cpp was quite helpful. It runs without asserts a fresh
 install of Ubuntu 12.04.

 The problem with the patch is that, as you said, it is too heavy handed.
 It looses too much information, both in comments and in code.

 On Linux, I'd prefer to try fchmodat with AT_SYMLINK_NOFOLLOW and then if
 it fails with ENOTSUP, try again with 0 instead of AT_SYMLINK_NOFOLLOW.
 That way the code will work correctly if Linux ever fixes
 AT_SYMLINK_NOFOLLOW. A comment is needed to explain why the code is
 written that way, too.

 I'd prefer you rework the patch, test it, and resubmit.

 Thanks,

 --Beman

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/6659#comment:11>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.