[Boost-bugs] [Boost C++ Libraries] #7253: [Boost.Build] Escape command line properly when calling assembler on MSVC

Subject: [Boost-bugs] [Boost C++ Libraries] #7253: [Boost.Build] Escape command line properly when calling assembler on MSVC
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2012-08-21 07:28:11

#7253: [Boost.Build] Escape command line properly when calling assembler on MSVC
------------------------------------------------------------+---------------
 Reporter:  Pekka Seppänen <pekka.seppanen@…>               |       Owner:  vladimir_prus
     Type:  Bugs                                            |      Status:  new          
Milestone:  To Be Determined                                |   Component:  build        
  Version:  Boost 1.51.0                                    |    Severity:  Problem      
 Keywords:  asm boost.context context command line invalid  |  
------------------------------------------------------------+---------------
 Hi.

 As of Boost.Context release (since Boost 1.51.0) assembler related build
 rules are actually used. However, currently these make no attempt
 whatsoever to properly escape the command line arguments (mostly global
 defines, that may have characters such as "<" and ">" that are interpreted
 by command prompt, not good).

 The following patch proxies command line arguments thru a RSP file, as
 done with C/C++ compiling/build rules.

 The patch does
         a) Add an ASM_RSPLINE under rule get-rspline,

         b) Add a rule compile.asm that calls get-rspline and compile-asm,

         c) Move the actual assembler call under actions compile-asm, that
 uses the generated ASM_RSPLINE,

         d) Remove toolset.flags msvc.compile.asm DEFINES as these are now
 inherited from toolset.flags msvc.compile DEFINES.


 That should fix it once and for all.

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/7253>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.