Re: [Boost-bugs] [Boost C++ Libraries] #6780: [BGL] add Maximum Adjacency Search

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #6780: [BGL] add Maximum Adjacency Search
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2012-08-25 12:32:43

#6780: [BGL] add Maximum Adjacency Search
-------------------------------+--------------------------------------------
  Reporter:  fvilas@…          |       Owner:  jewillco                    
      Type:  Patches           |      Status:  new                         
 Milestone:  To Be Determined  |   Component:  graph                       
   Version:  Boost 1.48.0      |    Severity:  Problem                     
Resolution:                    |    Keywords:  BGL Maximum Adjacency Search
-------------------------------+--------------------------------------------

Comment (by fvilas@…):

 Thanks for the help. I will work on addressing these.

 The mas_visitor_event_not_overridden was a copy/paste from
 breadth_first_search.hpp. I can change the values to void, but I thought
 there was a reason for it in the BFS code, so I used that example.

 The unsigned long will be converted to the key_type of the priority queue.

 isomorphism.hpp has a few new named parameter macros that I was unfamiliar
 with, but it should clean up the code, so I will try that.

 It looks like the BOOST_AUTO macro is only used in the examine_edge()
 routine in the Stoer-Wagner visitor to get the weight map type. I was
 unaware that the macro caused some issues, so I will get that fixed.

 The conversion to pass-by-value happened when chasing down some "reference
 of reference" bugs. I forgot to put it back. I just fixed that and the
 code seems to compile and run fine.

 It may take me a bit to get this list implemented, especially getting more
 familiar with the named parameters macros. I will put up a v5 of the patch
 as soon as I have something, so we can keep things moving. Thanks again
 for the feedback.

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/6780#comment:7>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.