Re: [Boost-bugs] [Boost C++ Libraries] #4919: gil_concept.hpp triggers self-assignment warnings

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #4919: gil_concept.hpp triggers self-assignment warnings
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2012-11-14 10:59:28

#4919: gil_concept.hpp triggers self-assignment warnings
--------------------------------+-------------------------------------------
  Reporter:  gromer@…           |       Owner:  marshall
      Type:  Patches            |      Status:  new     
 Milestone:  To Be Determined   |   Component:  GIL     
   Version:  Boost 1.45.0       |    Severity:  Problem 
Resolution:                     |    Keywords:          
--------------------------------+-------------------------------------------
Changes (by mikhailberis):

  * owner:  hljin => marshall

Comment:

 Replying to [comment:2 gromer@…]:
 > Please note that the attached patch does not completely resolve the
 issue; as noted in the summary I do not know what the correct resolution
 is for the self-assignment in PointNDConcept, because either the code is
 incorrect or the documentation is incomplete, and I don't know which.

 Okay, I had a look at this and it seems that PointNDConcept<T> does imply
 that it should be Regular<T>. This means it supports all the regular type
 requirements.

 Because this is a concept check it means whatever is in the concept
 definition determines the requirements. I'm inclined to think that merely
 switching the assignment to:

 {{{
 value_type v = p[0];
 p[0] = v;
 }}}

 Should fix the issue properly. I'll attach a new patch that should fix
 this.

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/4919#comment:4>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.