[Boost-bugs] [Boost C++ Libraries] #7757: Unnatural comment and fixing in Boost.Context

Subject: [Boost-bugs] [Boost C++ Libraries] #7757: Unnatural comment and fixing in Boost.Context
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2012-12-03 13:24:02

#7757: Unnatural comment and fixing in Boost.Context
----------------------------------------+-----------------------------------
 Reporter:  pn.suzuki.kojiro@…          |       Owner:  olli   
     Type:  Bugs                        |      Status:  new    
Milestone:  To Be Determined            |   Component:  context
  Version:  Boost 1.52.0                |    Severity:  Problem
 Keywords:                              |  
----------------------------------------+-----------------------------------
 Hello.

 In boost_1_52_0, I found a problem in
 libs/context/src/asm/jump_x86_64_ms_pe_masm.asm.

 line 52:

 ;  |   0x80   |  0x84  |  0x88   |  0x8c   |   0x90   |   0x94  |   0x98
 |   0x9c  |

 line 59:

 ;  |   0x100  |  0x104  |  0x108  |  0x10c |   0x110  |  0x114  |  0x118
 |  0x11c  |

 The address in line 52 began from 0x80, and the size of line 52 is 0x20.
 Therefore, the address in line 59 must be began from 0x0a0,

 line 118:
     movaps  [rcx+0100h],  xmm8

 This address "rcx+0100h" must be "rcx+00a0h" or it will destroy stack.

 In latest source code in trunk(Revision 81690),
 the source code were already changed, and it have no problem about
 running.

 As a result, these changes "fixed" the problem,
 but still it have same problem in comment, and the change is unnatural.


 I'm not good at English.
 Thanks.

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/7757>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.