Re: [Boost-bugs] [Boost C++ Libraries] #7788: locale_data::parse could be simplified

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #7788: locale_data::parse could be simplified
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2012-12-21 14:49:26

#7788: locale_data::parse could be simplified
--------------------------------------+-------------------------------------
  Reporter:  166291@…                 |       Owner:  artyom      
      Type:  Patches                  |      Status:  closed      
 Milestone:  To Be Determined         |   Component:  locale      
   Version:  Boost Development Trunk  |    Severity:  Optimization
Resolution:  invalid                  |    Keywords:              
--------------------------------------+-------------------------------------
Changes (by artyom):

  * status:  new => closed
  * resolution:  => invalid

Comment:

 Several notes:

 1. You can't use toupper or isalpha as they are locale sencitive and may
 accept characters outside of ASCII scope
 2. It does not the same, for example, the code allows to accept "-" and
 language-country separator

 The code is so complex because it tries to do the best to guess the locale

 > It does allow invalid locale names

 This is ''very important'' part, many OSes do very crazy stuff, so I try
 to guess as much as I can.

 Sorry I can't accept this patch.

 If you can improve the code readability and maintainablility without
 changing the scope if this function feel free to reopen this ticked and
 submit a new patch.

 Thanks for your effort.

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/7788#comment:2>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.