Re: [Boost-bugs] [Boost C++ Libraries] #7949: Level 4 Warnings with VS2005

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #7949: Level 4 Warnings with VS2005
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2013-02-01 09:58:56

#7949: Level 4 Warnings with VS2005
----------------------------------------------------------+-----------------
  Reporter:  Peter Brockamp <p.brockamp@…>                |       Owner:  apolukhin      
      Type:  Bugs                                         |      Status:  closed         
 Milestone:  Boost 1.54.0                                 |   Component:  lexical_cast   
   Version:  Boost 1.52.0                                 |    Severity:  Optimization   
Resolution:  wontfix                                      |    Keywords:  warnings VS2005
----------------------------------------------------------+-----------------

Comment (by Peter Brockamp <p.brockamp@…>):

 Replying to [comment:2 apolukhin]:
 > Working around buggy warnings on non default warning level - I don't
 think that it is worth doing in lexical_cast.

 Well, maybe it is not, yes. Admittedly this particular warning is rather
 braindead under some circumstances (notably more or less unneccessary
 integer promotion done by the compiler behind the scenes. Short int seems
 to be treated as a second class citizen here). Anyway, consider:
 * The problem with warnings coming from headers of course is that they
 often will popup in every including cpp-file or at every place an certain
 template instance is used, cluttering the build output and
 hindering/demotivating programmers fixing their selfmade warnings.
 * There are companies that implement a zero-warning-policy - they have a
 reason to do so.
 * "Tightening the screws" on programmers by increasing the warning level
 '''is''' a useful thing, it often leads the way to uncover hidden, subtle
 bugs.
 * Boost itself states they intend to make warning free headers for every
 supported compiler - with additional warnings enabled (/W4, -Wall, etc.).
 * Many programmers unfortunately are bound to a certain compiler/compiler
 version - and to being molested by the warnings it emmits, no matter
 whether they're buggy or not.
 So that's why I submitted this, and the patch is just a #pragma to shut
 down the warnings in lexical_cast, no line of production code is being
 changed. But never mind, that's just my personal opinion and everyone's
 summoned to have their personal opinion.

 Best regards

 Peter

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/7949#comment:3>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.