Re: [Boost-bugs] [Boost C++ Libraries] #8034: Warning fixes in multi_index

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #8034: Warning fixes in multi_index
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2013-02-12 12:20:26

#8034: Warning fixes in multi_index
--------------------------------------------------------------+-------------
  Reporter:  Franz Detro <franz.detro@…>                      |       Owner:  joaquin    
      Type:  Patches                                          |      Status:  new        
 Milestone:  To Be Determined                                 |   Component:  multi_index
   Version:  Boost 1.53.0                                     |    Severity:  Cosmetic   
Resolution:                                                   |    Keywords:             
--------------------------------------------------------------+-------------

Comment (by Franz Detro <franz.detro@…>):

 I've attached a compile log with the warnings. I didn't supply a fix,
 because these are exactly the kind of issues for which the warning is made
 for. For the non-maintainer (and maybe even for you) it's really hard to
 see which places need to be fixed and which not :

 e.g. const CompatibleHash& hash,const CompatiblePred& eq)const
   {
     std::size_t       buc=buckets.position(hash(k));

 I guess the class CompatibleHash has an operator () which creates a hash
 and I need to fix it here. But if this is not the case and hash(aValue) is
 a member of the class hashed_index, it probably shouldn't be fixed.

 I didn't dig into the details, but maybe you understand that such code is
 *really* hard to read (and even harder to fix) for non-maintainers.

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/8034#comment:4>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.