[Boost-bugs] [Boost C++ Libraries] #8082: Unused function w32_cat_get() in regex

Subject: [Boost-bugs] [Boost C++ Libraries] #8082: Unused function w32_cat_get() in regex
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2013-02-16 22:10:53

#8082: Unused function w32_cat_get() in regex
------------------------------+---------------------------------------------
 Reporter:  pjtsu             |       Owner:  johnmaddock
     Type:  Bugs              |      Status:  new        
Milestone:  To Be Determined  |   Component:  regex      
  Version:  Boost 1.53.0      |    Severity:  Problem    
 Keywords:                    |  
------------------------------+---------------------------------------------
 I think w32_cat_get() in w32_regex_traits.cpp is unused by regex.[[BR]]
 w32_cat_get() calls LoadStringA() and LoadStringW() of USER32.dll.[[BR]]
 If w32_cat_get() is deleted, libboost_regex-*.lib can link to just only
 KERNEL32.dll.[[BR]]

 If w32_cat_get() remains, I think revision is necessary.[[BR]]
 Destination buffer of !WideCharToMultiByte() in w32_regex_traits.cpp may
 be shortage,[[BR]]
 because not a letter of all !MultiByte-!CodePages are in 2 bytes.[[BR]]
 Constant value '''MB_LEN_MAX''' should be instead of '''2'''.[[BR]]
 MB_LEN_MAX is in <climits> header.[[BR]]

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/8082>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.